Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2078393005: mash: Move accessibility_types.h from ui namespace to ash namespace (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, sadrul, oshima+watch_chromium.org, aboxhall+watch_chromium.org, achuith+watch_chromium.org, dzhioev+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@a11y
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move accessibility_types.h from ui namespace to ash namespace It used to live in the ui namespace but the file moved to //ash. * Find-and-replace changes across //ash and //chrome/browser * Fix some include-what-you-use violations BUG=621574 TEST=compiles, ash_unittests TBR=stevenjb@chromium.org for mechanical changes in //chrome/browser/chromeos CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e Cr-Commit-Position: refs/heads/master@{#400872}

Patch Set 1 #

Patch Set 2 : fix chromevox code generated from js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -282 lines) Patch
M ash/accelerators/accelerator_controller.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 6 chunks +11 lines, -13 lines 0 comments Download
M ash/accelerators/spoken_feedback_toggler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/ash_touch_exploration_manager_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_touch_exploration_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/accessibility_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/common/accessibility_types.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/common/default_accessibility_delegate.h View 5 chunks +8 lines, -7 lines 0 comments Download
M ash/common/default_accessibility_delegate.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M ash/common/system/accessibility_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/wm_system_tray_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/wm_system_tray_notifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/keyboard/keyboard_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ash/system/ime/tray_ime_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_accessibility.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 14 chunks +32 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 10 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 21 chunks +54 lines, -53 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 17 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
James Cook
msw, please take a look (and feel free to rubber-stamp if you like).
4 years, 6 months ago (2016-06-20 20:02:55 UTC) #2
msw
lgtm
4 years, 6 months ago (2016-06-21 01:03:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078393005/20001
4 years, 6 months ago (2016-06-21 01:13:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 01:44:22 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 01:46:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7f8dabce6434cde68505212a2d8b2ef6e5dda7e
Cr-Commit-Position: refs/heads/master@{#400872}

Powered by Google App Engine
This is Rietveld 408576698