Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2084733002: mash: Move tray accessibility and keyboard to //ash/common (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@typenamespace
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move tray accessibility and keyboard to //ash/common These are dependencies of tray IME and status area widget, both of which I'm trying to move. This is a purely mechanical change: * Move //ash/keyboard to //ash/common/keyboard * Move //ash/system/tray_accessibility.* to //ash/common/system/ * Move //ash/system/tray/tray_details_view.* to //ash/common/system/tray BUG=619636 TEST=compiles, ash_unittests TBR=msw@chromium.org for purely mechanical move Committed: https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1 Cr-Commit-Position: refs/heads/master@{#401009}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1260 lines) Patch
M ash/ash.gyp View 7 chunks +8 lines, -8 lines 0 comments Download
A + ash/common/keyboard/keyboard_ui.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/keyboard/keyboard_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ash/common/keyboard/keyboard_ui_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_details_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/tray_details_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray_accessibility.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/tray_accessibility.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ash/keyboard/keyboard_ui.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ash/keyboard/keyboard_ui.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D ash/keyboard/keyboard_ui_observer.h View 1 chunk +0 lines, -23 lines 0 comments Download
M ash/shell.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/cast/tray_cast.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/audio/audio_detailed_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/bluetooth/tray_bluetooth.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_detailed_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/ime/tray_ime_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/system/tray/tray_details_view.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ash/system/tray/tray_details_view.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D ash/system/tray/tray_details_view_unittest.cc View 1 chunk +0 lines, -275 lines 0 comments Download
D ash/system/tray_accessibility.h View 1 chunk +0 lines, -143 lines 0 comments Download
D ash/system/tray_accessibility.cc View 1 chunk +0 lines, -421 lines 0 comments Download
M ash/sysui/keyboard_ui_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/keyboard_ui_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084733002/20001
4 years, 6 months ago (2016-06-21 15:49:01 UTC) #4
commit-bot: I haz the power
Failed to apply patch for ash/common/keyboard/keyboard_ui.cc: While running git apply --index -3 -p1; error: ash/keyboard/keyboard_ui.cc: ...
4 years, 6 months ago (2016-06-21 16:32:57 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1 Cr-Commit-Position: refs/heads/master@{#401009}
4 years, 6 months ago (2016-06-21 16:34:35 UTC) #8
msw
4 years, 6 months ago (2016-06-21 18:00:33 UTC) #9
Message was sent while issue was closed.
lgtm, but please send a message out to let me know about the TBR. (I just barely
caught this above the noise of my email inbox)

Powered by Google App Engine
This is Rietveld 408576698