Convert TrayAccessibility to wm common types

Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636, 621574
TEST=ash_unittests
TBR=atwilson@chromium.org for mechanical change to //chrome/browser/policy

Committed: https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25
Cr-Commit-Position: refs/heads/master@{#400791}

[James Cook, 2016-06-17 23:55:59]

Description was changed from

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is only
used in ash code
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

BUG=619636
TEST=ash_unittests
==========

to

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636
TEST=ash_unittests
==========

[James Cook, 2016-06-18 00:00:02]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org, stevenjb@chromium.org

[James Cook, 2016-06-18 00:00:03]

msw, please take a look at //ash.

stevenjb, please take a look at //ui/chromeos. (The accessibility_types.h file
is used on windows, which we are using for mustash development. DEPS probably
didn't catch it because of "+ui" in ash/DEPS.)

[msw, 2016-06-18 01:15:06]

https://codereview.chromium.org/2074913005/diff/20001/ash/common/accessibilit...
File ash/common/accessibility_types.h (right):

https://codereview.chromium.org/2074913005/diff/20001/ash/common/accessibilit...
ash/common/accessibility_types.h:8: namespace ui {
It seems odd to move this file to ash/ but keep the ui::namespace...

https://codereview.chromium.org/2074913005/diff/20001/ash/keyboard/keyboard_u...
File ash/keyboard/keyboard_ui.cc (right):

https://codereview.chromium.org/2074913005/diff/20001/ash/keyboard/keyboard_u...
ash/keyboard/keyboard_ui.cc:21:
WmShell::Get()->system_tray_notifier()->AddAccessibilityObserver(this);
Shouldn't this be removed on destruction? (if the shell && notifier exist)

[James Cook, 2016-06-20 17:27:34]

msw / stevenjb - please take another look.

https://codereview.chromium.org/2074913005/diff/20001/ash/common/accessibilit...
File ash/common/accessibility_types.h (right):

https://codereview.chromium.org/2074913005/diff/20001/ash/common/accessibilit...
ash/common/accessibility_types.h:8: namespace ui {
On 2016/06/18 01:15:06, msw wrote:
> It seems odd to move this file to ash/ but keep the ui::namespace...

Oops, I forgot my TODO. Added. I would prefer to do this in a separate CL
because it touches dozens of files in hundreds of locations.

Is that OK? Or would you like me to do the file move/namespace cleanup in a CL
before this one?

https://codereview.chromium.org/2074913005/diff/20001/ash/keyboard/keyboard_u...
File ash/keyboard/keyboard_ui.cc (right):

https://codereview.chromium.org/2074913005/diff/20001/ash/keyboard/keyboard_u...
ash/keyboard/keyboard_ui.cc:21:
WmShell::Get()->system_tray_notifier()->AddAccessibilityObserver(this);
On 2016/06/18 01:15:06, msw wrote:
> Shouldn't this be removed on destruction? (if the shell && notifier exist)

Good catch. Done.

[James Cook, 2016-06-20 17:27:54]

Description was changed from

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636
TEST=ash_unittests
==========

to

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636,621574
TEST=ash_unittests
==========

[msw, 2016-06-20 17:35:56]

lgtm

https://codereview.chromium.org/2074913005/diff/20001/ash/common/accessibilit...
File ash/common/accessibility_types.h (right):

https://codereview.chromium.org/2074913005/diff/20001/ash/common/accessibilit...
ash/common/accessibility_types.h:8: namespace ui {
On 2016/06/20 17:27:33, James Cook wrote:
> On 2016/06/18 01:15:06, msw wrote:
> > It seems odd to move this file to ash/ but keep the ui::namespace...
> 
> Oops, I forgot my TODO. Added. I would prefer to do this in a separate CL
> because it touches dozens of files in hundreds of locations.
> 
> Is that OK? Or would you like me to do the file move/namespace cleanup in a CL
> before this one?

Yeah, a followup is fine, I can do that namespace change if you want.

[stevenjb, 2016-06-20 17:49:17]

lgtm

https://codereview.chromium.org/2074913005/diff/40001/ash/system/tray_accessi...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/2074913005/diff/40001/ash/system/tray_accessi...
ash/system/tray_accessibility.cc:201:
WmShell::Get()->GetSessionStateDelegate()->IsInSecondaryLoginScreen())
We really should do a (separate) cleanup pass to combine all instances of the
above logic (including places that don't check for LOCKED but probably should)
and replace them with something like WmShell::Get()->IsInLoginOrLockScreen().

[James Cook, 2016-06-20 18:01:20]

On 2016/06/20 17:49:17, stevenjb wrote:
> lgtm
> 
>
https://codereview.chromium.org/2074913005/diff/40001/ash/system/tray_accessi...
> File ash/system/tray_accessibility.cc (right):
> 
>
https://codereview.chromium.org/2074913005/diff/40001/ash/system/tray_accessi...
> ash/system/tray_accessibility.cc:201:
> WmShell::Get()->GetSessionStateDelegate()->IsInSecondaryLoginScreen())
> We really should do a (separate) cleanup pass to combine all instances of the
> above logic (including places that don't check for LOCKED but probably should)
> and replace them with something like WmShell::Get()->IsInLoginOrLockScreen().

I filed http://crbug.com/621598 to track this cleanup.

msw, I'll do the namespace change. I have most of the queries to do it in
history.

[James Cook, 2016-06-20 19:50:48]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-20 19:50:49]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2074913005/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-20 19:51:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074913005/80001

[James Cook, 2016-06-20 19:58:29]

Description was changed from

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636,621574
TEST=ash_unittests
==========

to

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636,621574
TEST=ash_unittests
TBR=atwilson@chromium.org for mechanical change to //chrome/browser/policy
==========

[commit-bot: I haz the power, 2016-06-20 20:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 20:30:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-06-20 20:50:44]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-06-20 20:51:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074913005/80001

[commit-bot: I haz the power, 2016-06-20 21:37:25]

Description was changed from

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636,621574
TEST=ash_unittests
TBR=atwilson@chromium.org for mechanical change to //chrome/browser/policy
==========

to

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636,621574
TEST=ash_unittests
TBR=atwilson@chromium.org for mechanical change to //chrome/browser/policy
==========

[commit-bot: I haz the power, 2016-06-20 21:37:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-20 21:40:00]

Description was changed from

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636,621574
TEST=ash_unittests
TBR=atwilson@chromium.org for mechanical change to //chrome/browser/policy
==========

to

==========
Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636,621574
TEST=ash_unittests
TBR=atwilson@chromium.org for mechanical change to //chrome/browser/policy

Committed: https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25
Cr-Commit-Position: refs/heads/master@{#400791}
==========

[commit-bot: I haz the power, 2016-06-20 21:40:01]

Patchset 5 (id:??) landed as
https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25
Cr-Commit-Position: refs/heads/master@{#400791}