Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2078253002: vector<unique_ptr> for PasswordFormManager::blacklisted_matches_ (Closed)

Created:
4 years, 6 months ago by vabr (Chromium)
Modified:
4 years, 6 months ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

vector<unique_ptr> for PasswordFormManager::blacklisted_matches_ This CL changes the type of PasswordFormManager::blacklisted_matches_ from ScopedVector to std::vector<std::unique_ptr>>. BUG=555132 Committed: https://crrev.com/d302f872682eb0c4ae8891db4ec1633fba824f8c Cr-Commit-Position: refs/heads/master@{#400633}

Patch Set 1 #

Patch Set 2 : Fix UI controller #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
vabr (Chromium)
Fix UI controller
4 years, 6 months ago (2016-06-19 15:55:42 UTC) #1
vabr (Chromium)
Hi Vadym, Please take a look. Cheers, Vaclav
4 years, 6 months ago (2016-06-19 16:41:05 UTC) #3
dvadym
On 2016/06/19 16:41:05, vabr (Chromium) wrote: > Hi Vadym, > > Please take a look. ...
4 years, 6 months ago (2016-06-20 07:54:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078253002/20001
4 years, 6 months ago (2016-06-20 07:58:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 08:02:53 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 08:04:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d302f872682eb0c4ae8891db4ec1633fba824f8c
Cr-Commit-Position: refs/heads/master@{#400633}

Powered by Google App Engine
This is Rietveld 408576698