components/password_manager/core/browser/password_form_manager.h - Issue 2078253002: vector<unique_ptr> for PasswordFormManager::blacklisted_matches_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 2078253002: vector<unique_ptr> for PasswordFormManager::blacklisted_matches_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix UI controller Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index cfe2176d61eb77dc2222c5362121038902b76079..5e25d390fc5a179895133b35e491340f58b769e5 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -219,7 +219,8 @@ class PasswordFormManager : public PasswordStoreConsumer {

return preferred_match_;

}

- const ScopedVector<autofill::PasswordForm>& blacklisted_matches() const {

+ const std::vector<std::unique_ptr<autofill::PasswordForm>>&

+ blacklisted_matches() const {

return blacklisted_matches_;

}

@@ -481,7 +482,7 @@ class PasswordFormManager : public PasswordStoreConsumer {

// Set of blacklisted forms from the PasswordStore that best match the current

// form.

- ScopedVector<autofill::PasswordForm> blacklisted_matches_;

+ std::vector<std::unique_ptr<autofill::PasswordForm>> blacklisted_matches_;

// The PasswordForm from the page or dialog managed by |this|.

const autofill::PasswordForm observed_form_;