[builtins] Introduce proper Float64Exp operator.

[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3266, v8:3468, v8:3493, v8:5086, v8:5108, chromium:620786
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Committed: https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37
Cr-Original-Commit-Position: refs/heads/master@{#37037}
Cr-Commit-Position: refs/heads/master@{#37047}

[Benedikt Meurer, 2016-06-16 09:50:59]

bmeurer@chromium.org changed reviewers:
+ ahaas@chromium.org

[Benedikt Meurer, 2016-06-16 09:51:00]

Hey Michael,

Here's the exp one, that unblocks sinh and friends.
Please take a look.

Thanks,
Benedikt

Andreas: FYI (wasm<-asm port)

[mvstanton, 2016-06-16 11:19:48]

lgtm

[Benedikt Meurer, 2016-06-16 11:35:21]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-16 11:35:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2077533002/#ps80001
(title: "REBASE")

[commit-bot: I haz the power, 2016-06-16 11:35:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077533002/80001

[commit-bot: I haz the power, 2016-06-16 12:10:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-16 12:10:34]

Description was changed from

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
R=mvstanton@chromium.org
==========

to

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

[commit-bot: I haz the power, 2016-06-16 12:10:35]

Patchset 5 (id:??) landed as
https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}

[Michael Achenbach, 2016-06-16 12:47:53]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2070813002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Leads to some different rounding as it
seems in some audio layout tests. Please rebase upstream first if intended:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Raymond Toy, 2016-06-16 15:12:26]

On 2016/06/16 12:47:53, Michael Achenbach wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/2070813002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Leads to some different rounding as it
> seems in some audio layout tests. Please rebase upstream first if intended:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

The test seem to pass, just the printed results are different.

As an owner of the webaudio tests, I would be happy to coordinate with you on
getting this CL landed.

I think we can just skip these tests for now, so that your CL can land.  Then I
can update the expected results afterwards and re-enable these tests.

[Raymond Toy, 2016-06-16 15:14:39]

rtoy@chromium.org changed reviewers:
+ rtoy@chromium.org

[Raymond Toy, 2016-06-16 15:14:40]

It seems you don't have any tests.  Should you? I wrote up a few tests for
fdlibm-js exp a while ago.  You might be interested in adding them. I can help
integrate them, if you want the tests.

[Benedikt Meurer, 2016-06-16 17:08:25]

On 2016/06/16 15:14:40, Raymond Toy wrote:
> It seems you don't have any tests.  Should you? I wrote up a few tests for
> fdlibm-js exp a while ago.  You might be interested in adding them. I can help
> integrate them, if you want the tests.

The tests are in the ieee754-unittests.cc file. I'm currently migrating a few
edge cases from your test file. Feel free to add more useful tests.

[Benedikt Meurer, 2016-06-16 17:08:53]

Description was changed from

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

to

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

[Benedikt Meurer, 2016-06-16 17:09:32]

Description was changed from

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

to

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

[Benedikt Meurer, 2016-06-16 17:09:44]

Patchset #2 (id:20001) has been deleted

[Benedikt Meurer, 2016-06-16 17:09:57]

Patchset #2 (id:40001) has been deleted

[Benedikt Meurer, 2016-06-16 17:10:11]

Patchset #2 (id:60001) has been deleted

[Benedikt Meurer, 2016-06-16 17:10:40]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 17:10:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077533002/100001

[Raymond Toy, 2016-06-16 17:11:44]

On 2016/06/16 17:08:25, Benedikt Meurer wrote:
> On 2016/06/16 15:14:40, Raymond Toy wrote:
> > It seems you don't have any tests.  Should you? I wrote up a few tests for
> > fdlibm-js exp a while ago.  You might be interested in adding them. I can
help
> > integrate them, if you want the tests.
> 
> The tests are in the ieee754-unittests.cc file. I'm currently migrating a few
> edge cases from your test file. Feel free to add more useful tests.

Oh, I missed that file.  That's really fantastic!

I'm really excited to see these changes.

[Benedikt Meurer, 2016-06-16 17:33:45]

Description was changed from

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

to

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108,chromium:620786
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

[Benedikt Meurer, 2016-06-16 18:11:28]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-16 18:11:40]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-16 18:11:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2077533002/#ps100001
(title: "REBASE. Import tests from Raymond.")

[commit-bot: I haz the power, 2016-06-16 18:11:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077533002/100001

[Raymond Toy, 2016-06-16 18:12:44]

https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ie...
File test/unittests/base/ieee754-unittest.cc (right):

https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ie...
test/unittests/base/ieee754-unittest.cc:62: EXPECT_EQ(0.0,
exp(-745.1332191019412));
DBC:  It might be useful to add comments on what these tests are actually doing.
 At a glance, they just look like lots of random numbers, but they have specific
meanings and are testing certain behaviors.

[Benedikt Meurer, 2016-06-16 18:13:53]

https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ie...
File test/unittests/base/ieee754-unittest.cc (right):

https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ie...
test/unittests/base/ieee754-unittest.cc:62: EXPECT_EQ(0.0,
exp(-745.1332191019412));
May we ask you for help on these and the other fdlibm function tests? You seem
to have a lot more background here.

[Raymond Toy, 2016-06-16 18:34:30]

https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ie...
File test/unittests/base/ieee754-unittest.cc (right):

https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ie...
test/unittests/base/ieee754-unittest.cc:62: EXPECT_EQ(0.0,
exp(-745.1332191019412));
On 2016/06/16 18:13:53, Benedikt Meurer wrote:
> May we ask you for help on these and the other fdlibm function tests? You seem
> to have a lot more background here.

No problem.  I'll look into them shortly.  I see that I was also pretty sloppy
about documenting the tests that I wrote. It will take some time.

But don't let this block landing these changes!

[Benedikt Meurer, 2016-06-16 19:00:50]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-16 19:00:59]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-06-16 19:01:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077533002/100001

[commit-bot: I haz the power, 2016-06-16 19:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 19:47:00]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[Benedikt Meurer, 2016-06-17 03:48:01]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-06-17 03:48:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077533002/100001

[commit-bot: I haz the power, 2016-06-17 05:19:44]

Description was changed from

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108,chromium:620786
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

to

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108,chromium:620786
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

[commit-bot: I haz the power, 2016-06-17 05:19:46]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-06-17 05:21:04]

Description was changed from

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108,chromium:620786
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Cr-Commit-Position: refs/heads/master@{#37037}
==========

to

==========
[builtins] Introduce proper Float64Exp operator.

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108,chromium:620786
R=mvstanton@chromium.org

Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
Committed: https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37
Cr-Original-Commit-Position: refs/heads/master@{#37037}
Cr-Commit-Position: refs/heads/master@{#37047}
==========

[commit-bot: I haz the power, 2016-06-17 05:21:05]

Patchset 3 (id:??) landed as
https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37
Cr-Commit-Position: refs/heads/master@{#37047}