Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2077533002: [builtins] Introduce proper Float64Exp operator. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce proper Float64Exp operator. Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.exp() as TurboFan builtin and use that operator to also inline Math.exp() into optimized TurboFan functions. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel BUG=v8:3266, v8:3468, v8:3493, v8:5086, v8:5108, chromium:620786 R=mvstanton@chromium.org Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260 Committed: https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37 Cr-Original-Commit-Position: refs/heads/master@{#37037} Cr-Commit-Position: refs/heads/master@{#37047}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : REBASE. Import tests from Raymond. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -1181 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +0 lines, -150 lines 0 comments Download
M src/arm64/codegen-arm64.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 2 chunks +0 lines, -181 lines 0 comments Download
M src/assembler.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M src/assembler.cc View 1 5 chunks +6 lines, -74 lines 0 comments Download
M src/base/ieee754.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/base/ieee754.cc View 1 1 chunk +146 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/codegen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/codegen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 3 chunks +8 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 1 chunk +2 lines, -15 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 1 chunk +2 lines, -19 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 1 chunk +4 lines, -11 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 1 chunk +2 lines, -12 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 1 chunk +2 lines, -15 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 1 chunk +2 lines, -15 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 1 chunk +2 lines, -10 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/external-reference-table.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +0 lines, -95 lines 0 comments Download
M src/js/math.js View 3 chunks +0 lines, -7 lines 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +0 lines, -17 lines 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +0 lines, -143 lines 0 comments Download
M src/mips64/codegen-mips64.h View 1 chunk +0 lines, -17 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 2 chunks +0 lines, -141 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 3 chunks +5 lines, -7 lines 0 comments Download
M src/v8.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +0 lines, -85 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M test/unittests/base/ieee754-unittest.cc View 1 2 1 chunk +28 lines, -0 lines 3 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 42 (21 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-16 09:50:13 UTC) #1
Benedikt Meurer
Hey Michael, Here's the exp one, that unblocks sinh and friends. Please take a look. ...
4 years, 6 months ago (2016-06-16 09:51:00 UTC) #3
mvstanton
lgtm
4 years, 6 months ago (2016-06-16 11:19:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077533002/80001
4 years, 6 months ago (2016-06-16 11:35:27 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-16 12:10:06 UTC) #8
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260 Cr-Commit-Position: refs/heads/master@{#37037}
4 years, 6 months ago (2016-06-16 12:10:35 UTC) #10
Michael Achenbach
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2070813002/ by machenbach@chromium.org. ...
4 years, 6 months ago (2016-06-16 12:47:53 UTC) #11
Raymond Toy
On 2016/06/16 12:47:53, Michael Achenbach wrote: > A revert of this CL (patchset #5 id:80001) ...
4 years, 6 months ago (2016-06-16 15:12:26 UTC) #12
Raymond Toy
It seems you don't have any tests. Should you? I wrote up a few tests ...
4 years, 6 months ago (2016-06-16 15:14:40 UTC) #14
Benedikt Meurer
On 2016/06/16 15:14:40, Raymond Toy wrote: > It seems you don't have any tests. Should ...
4 years, 6 months ago (2016-06-16 17:08:25 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077533002/100001
4 years, 6 months ago (2016-06-16 17:10:47 UTC) #22
Raymond Toy
On 2016/06/16 17:08:25, Benedikt Meurer wrote: > On 2016/06/16 15:14:40, Raymond Toy wrote: > > ...
4 years, 6 months ago (2016-06-16 17:11:44 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077533002/100001
4 years, 6 months ago (2016-06-16 18:11:50 UTC) #28
Raymond Toy
https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ieee754-unittest.cc File test/unittests/base/ieee754-unittest.cc (right): https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ieee754-unittest.cc#newcode62 test/unittests/base/ieee754-unittest.cc:62: EXPECT_EQ(0.0, exp(-745.1332191019412)); DBC: It might be useful to add ...
4 years, 6 months ago (2016-06-16 18:12:44 UTC) #29
Benedikt Meurer
https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ieee754-unittest.cc File test/unittests/base/ieee754-unittest.cc (right): https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ieee754-unittest.cc#newcode62 test/unittests/base/ieee754-unittest.cc:62: EXPECT_EQ(0.0, exp(-745.1332191019412)); May we ask you for help on ...
4 years, 6 months ago (2016-06-16 18:13:53 UTC) #30
Raymond Toy
https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ieee754-unittest.cc File test/unittests/base/ieee754-unittest.cc (right): https://codereview.chromium.org/2077533002/diff/100001/test/unittests/base/ieee754-unittest.cc#newcode62 test/unittests/base/ieee754-unittest.cc:62: EXPECT_EQ(0.0, exp(-745.1332191019412)); On 2016/06/16 18:13:53, Benedikt Meurer wrote: > ...
4 years, 6 months ago (2016-06-16 18:34:30 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077533002/100001
4 years, 6 months ago (2016-06-16 19:01:09 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/87170)
4 years, 6 months ago (2016-06-16 19:47:00 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077533002/100001
4 years, 6 months ago (2016-06-17 03:48:11 UTC) #38
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 6 months ago (2016-06-17 05:19:46 UTC) #40
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 05:21:05 UTC) #42
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d5f2ac5e3326f281cbe7ba57464a4b17a9938e37
Cr-Commit-Position: refs/heads/master@{#37047}

Powered by Google App Engine
This is Rietveld 408576698