MD History: Add confirmation dialog when deleting items from the toolbar

MD History: Add confirmation dialog when deleting items from the toolbar

BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe
Cr-Commit-Position: refs/heads/master@{#404319}

[tsergeant, 2016-06-16 04:04:41]

Description was changed from

==========
MD History: Add confirmation dialog when deleting items from the toolbar


BUG=618579
==========

to

==========
MD History: Add confirmation dialog when deleting items from the toolbar


BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-07-07 00:41:07]

Patchset #3 (id:40001) has been deleted

[tsergeant, 2016-07-07 00:44:38]

Patchset #3 (id:60001) has been deleted

[tsergeant, 2016-07-07 00:46:18]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2016-07-07 00:46:19]

PTAL~!

[calamity, 2016-07-08 06:05:50]

lgtm

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.html (left):

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.html:32: </template>
=S

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:90: deleteSelected:
function() {
promptDeleteSelected perhaps? promptDeletion?

I just think it would be clearer if this had a different name from the actual
doDeleteSelected methid.

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:92: return;
nit: newline here.

[tsergeant, 2016-07-08 06:37:27]

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.html (left):

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.html:32: </template>
On 2016/07/08 06:05:50, calamity wrote:
> =S

yeahhhhhhhhh

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:90: deleteSelected:
function() {
On 2016/07/08 06:05:50, calamity wrote:
> promptDeleteSelected perhaps? promptDeletion?
> 
> I just think it would be clearer if this had a different name from the actual
> doDeleteSelected methid.

Done.

https://codereview.chromium.org/2077483002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:92: return;
On 2016/07/08 06:05:50, calamity wrote:
> nit: newline here.

Done.

[tsergeant, 2016-07-08 06:37:32]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-07-08 06:37:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2077483002/#ps100001
(title: "Address nits")

[commit-bot: I haz the power, 2016-07-08 06:38:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 09:28:27]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-07-08 09:28:44]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 09:29:50]

Description was changed from

==========
MD History: Add confirmation dialog when deleting items from the toolbar


BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add confirmation dialog when deleting items from the toolbar

BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe
Cr-Commit-Position: refs/heads/master@{#404319}
==========

[commit-bot: I haz the power, 2016-07-08 09:29:51]

Patchset 4 (id:??) landed as
https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe
Cr-Commit-Position: refs/heads/master@{#404319}