Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2498)

Unified Diff: chrome/browser/resources/md_history/app.js

Issue 2077483002: MD History: Add confirmation dialog when deleting items from the toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cr_refactor_dialog
Patch Set: Address nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/app.js
diff --git a/chrome/browser/resources/md_history/app.js b/chrome/browser/resources/md_history/app.js
index 721e621ac3142c69ce9fc27d7e5ced01f381345a..fe23b4fab35cad632ef88cba05ac232d417122ee 100644
--- a/chrome/browser/resources/md_history/app.js
+++ b/chrome/browser/resources/md_history/app.js
@@ -85,18 +85,8 @@ Polymer({
toolbar.count = 0;
},
- /**
- * Listens for call to delete all selected items and loops through all items
- * to determine which ones are selected and deletes these.
- */
deleteSelected: function() {
- if (!loadTimeData.getBoolean('allowDeletingHistory'))
- return;
-
- // TODO(hsampson): add a popup to check whether the user definitely
- // wants to delete the selected items.
- /** @type {HistoryListContainerElement} */ (this.$['history'])
- .deleteSelected();
+ this.$.history.deleteSelectedWithPrompt();
},
/**
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698