chrome/browser/resources/md_history/history_list.js - Issue 2077483002: MD History: Add confirmation dialog when deleting items from the toolbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history_list.js

Issue 2077483002: MD History: Add confirmation dialog when deleting items from the toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cr_refactor_dialog

Patch Set: Address nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/md_history/history_list.js

diff --git a/chrome/browser/resources/md_history/history_list.js b/chrome/browser/resources/md_history/history_list.js

index 58a3cfe03bfe3da9ba7c3e3c90d9833d5e7539c0..ba358120f6b4f93984e925bb05bad7a508f37f7f 100644

--- a/chrome/browser/resources/md_history/history_list.js

+++ b/chrome/browser/resources/md_history/history_list.js

@@ -189,7 +189,9 @@ Polymer({

/**

* Performs a request to the backend to delete all selected items. If

- * successful, removes them from the view.

+ * successful, removes them from the view. Does not prompt the user before

+ * deleting -- see <history-list-container> for a version of this method which

+ * does prompt.

deleteSelected: function() {

var toBeRemoved = this.historyData_.filter(function(item) {

« no previous file with comments | « chrome/browser/resources/md_history/app.js ('k') | chrome/browser/resources/md_history/list_container.html » ('j') | no next file with comments »