Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2077223002: Flip all win chromium.fyi clang builders to GN. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_win_goma
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip all win chromium.fyi clang builders to GN. Now that nearly all of the msvs win builders are on GYP, the clang builders should be, too. R=thakis@chromium.org BUG=605318

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -63 lines) Patch
M tools/mb/mb_config.pyl View 1 9 chunks +63 lines, -63 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (3 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-19 05:15:36 UTC) #1
Nico
This doesn't work yet. On https://bugs.chromium.org/p/chromium/issues/detail?id=498033 I've gone through several flip-assess damage-unflip-fix-repeat cycles. The current ...
4 years, 6 months ago (2016-06-20 02:54:05 UTC) #2
Dirk Pranke
Now that the goma thing seems to work, what do you want to do with ...
4 years, 6 months ago (2016-06-22 04:12:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077223002/20001
4 years, 6 months ago (2016-06-22 04:48:52 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 05:49:24 UTC) #7
Nico
lgtm
4 years, 6 months ago (2016-06-22 13:53:24 UTC) #8
Nico
Actually, maybe it's better to flip only half. Let me land the rest of https://codereview.chromium.org/1947183004/ ...
4 years, 6 months ago (2016-06-22 13:54:25 UTC) #9
Dirk Pranke
4 years, 6 months ago (2016-06-22 15:28:36 UTC) #10
On 2016/06/22 13:54:25, Nico wrote:
> Actually, maybe it's better to flip only half. Let me land the rest of
> https://codereview.chromium.org/1947183004/ instead

ok.

Powered by Google App Engine
This is Rietveld 408576698