Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2084253002:
Flip more Mac builders to GN. (Closed)
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago Reviewers:
Robert Sesek CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_most_cros Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip more Mac builders to GN.
This flips the following builders to GN:
- chromium
- Mac
- chromium.chrome
- Google Chrome Mac
- chromium.perf
- Mac Builder
- tryserver.chromium.mac
- mac_chromium_10.10_rel_ng
- mac_chromium_archive_rel_ng
- mac_nacl_sdk
- mac_nacl_sdk_build
- mac_optional_gpu_tests_rel
Leaving pretty much just the internal official builders, the
memory/sanitizer builders, the angle trybots, and various fyi builders.
R=rsesek@chromium.org
BUG=618468
Committed: https://crrev.com/edf8327a75981f91e292a8eeca4fef7aa2a942a3
Cr-Commit-Position: refs/heads/master@{#401288}
Patch Set 1 #Patch Set 2 : flip the angle builders as well #Patch Set 3 : remove angle, macviews builders #
Total comments: 2
Patch Set 4 : merge #Messages
Total messages: 27 (10 generated)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084253002/1
Description was changed from ========== Flip more Mac builders to GN. This flips the following builders to GN: - chromium - Mac - chromium.chrome - Google Chrome Mac - chromium.fyi - Chromium Mac 10.10 MacViews - chromium.perf - Mac Builder - tryserver.chromium.mac - mac_chromium_10.10_rel_ng - mac_chromium_10.10_macviews - mac_chromium_archive_rel_ng - mac_nacl_sdk - mac_nacl_sdk_build - mac_optional_gpu_tests_rel Leaving pretty much just the internal official builders, the memory/sanitizer builders, and the clang tot builders. R=rsesek@chromium.org BUG=618468 ========== to ========== Flip more Mac builders to GN. This flips the following builders to GN: - chromium - Mac - chromium.chrome - Google Chrome Mac - chromium.fyi - Chromium Mac 10.10 MacViews - chromium.perf - Mac Builder - tryserver.angle - mac_angle_dbg_ng - mac_angle_rel_ng - tryserver.chromium.mac - mac_chromium_10.10_rel_ng - mac_chromium_10.10_macviews - mac_chromium_archive_rel_ng - mac_nacl_sdk - mac_nacl_sdk_build - mac_optional_gpu_tests_rel Leaving pretty much just the internal official builders, the memory/sanitizer builders, and various fyi builders. R=rsesek@chromium.org BUG=618468 ==========
I don't know if MacViews is ready to make the switch yet (https://crbug.com/611324) and am currently fixing a few issues with the GPU switch (https://crbug.com/621932).
On 2016/06/21 23:14:36, Robert Sesek wrote: > I don't know if MacViews is ready to make the switch yet > (https://crbug.com/611324) and am currently fixing a few issues with the GPU > switch (https://crbug.com/621932). Okay. Do you want me to wait on those and flip the others?
On 2016/06/21 23:22:43, Dirk Pranke wrote: > On 2016/06/21 23:14:36, Robert Sesek wrote: > > I don't know if MacViews is ready to make the switch yet > > (https://crbug.com/611324) and am currently fixing a few issues with the GPU > > switch (https://crbug.com/621932). > > Okay. Do you want me to wait on those and flip the others? Yeah, let's drop macviews and angle for now but I think the rest are good to go.
Description was changed from ========== Flip more Mac builders to GN. This flips the following builders to GN: - chromium - Mac - chromium.chrome - Google Chrome Mac - chromium.fyi - Chromium Mac 10.10 MacViews - chromium.perf - Mac Builder - tryserver.angle - mac_angle_dbg_ng - mac_angle_rel_ng - tryserver.chromium.mac - mac_chromium_10.10_rel_ng - mac_chromium_10.10_macviews - mac_chromium_archive_rel_ng - mac_nacl_sdk - mac_nacl_sdk_build - mac_optional_gpu_tests_rel Leaving pretty much just the internal official builders, the memory/sanitizer builders, and various fyi builders. R=rsesek@chromium.org BUG=618468 ========== to ========== Flip more Mac builders to GN. This flips the following builders to GN: - chromium - Mac - chromium.chrome - Google Chrome Mac - chromium.perf - Mac Builder - tryserver.chromium.mac - mac_chromium_10.10_rel_ng - mac_chromium_archive_rel_ng - mac_nacl_sdk - mac_nacl_sdk_build - mac_optional_gpu_tests_rel Leaving pretty much just the internal official builders, the memory/sanitizer builders, the angle trybots, and various fyi builders. R=rsesek@chromium.org BUG=618468 ==========
https://codereview.chromium.org/2084253002/diff/40001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (left): https://codereview.chromium.org/2084253002/diff/40001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:111: 'CrWin7Goma': 'gyp_release_bot_minimal_symbols_x86', Some Win stuff snuck in here too. May want to mention that in the CL description.
https://codereview.chromium.org/2084253002/diff/40001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (left): https://codereview.chromium.org/2084253002/diff/40001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:111: 'CrWin7Goma': 'gyp_release_bot_minimal_symbols_x86', On 2016/06/21 23:31:07, Robert Sesek wrote: > Some Win stuff snuck in here too. May want to mention that in the CL > description. Whoops. It wasn't supposed to. Too many git branches pipelined ... will fix.
On 2016/06/21 23:32:34, Dirk Pranke wrote: > https://codereview.chromium.org/2084253002/diff/40001/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (left): > > https://codereview.chromium.org/2084253002/diff/40001/tools/mb/mb_config.pyl#... > tools/mb/mb_config.pyl:111: 'CrWin7Goma': 'gyp_release_bot_minimal_symbols_x86', > On 2016/06/21 23:31:07, Robert Sesek wrote: > > Some Win stuff snuck in here too. May want to mention that in the CL > > description. > > Whoops. It wasn't supposed to. Too many git branches pipelined ... will fix. Actually fixing that correctly causes merge conflicts, and the win stuff is already in the CQ, so I'll clean it up again once the other patches land.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084253002/60001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084253002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. Trent says we may be able to flip the views bots too, actually. May want to just do that in a separate CL in case we need to revert it, though
On 2016/06/22 14:44:36, Robert Sesek wrote: > LGTM. Trent says we may be able to flip the views bots too, actually. May want > to just do that in a separate CL in case we need to revert it, though Ack. I will do that in a separate CL.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084253002/60001
Message was sent while issue was closed.
Description was changed from ========== Flip more Mac builders to GN. This flips the following builders to GN: - chromium - Mac - chromium.chrome - Google Chrome Mac - chromium.perf - Mac Builder - tryserver.chromium.mac - mac_chromium_10.10_rel_ng - mac_chromium_archive_rel_ng - mac_nacl_sdk - mac_nacl_sdk_build - mac_optional_gpu_tests_rel Leaving pretty much just the internal official builders, the memory/sanitizer builders, the angle trybots, and various fyi builders. R=rsesek@chromium.org BUG=618468 ========== to ========== Flip more Mac builders to GN. This flips the following builders to GN: - chromium - Mac - chromium.chrome - Google Chrome Mac - chromium.perf - Mac Builder - tryserver.chromium.mac - mac_chromium_10.10_rel_ng - mac_chromium_archive_rel_ng - mac_nacl_sdk - mac_nacl_sdk_build - mac_optional_gpu_tests_rel Leaving pretty much just the internal official builders, the memory/sanitizer builders, the angle trybots, and various fyi builders. R=rsesek@chromium.org BUG=618468 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Flip more Mac builders to GN. This flips the following builders to GN: - chromium - Mac - chromium.chrome - Google Chrome Mac - chromium.perf - Mac Builder - tryserver.chromium.mac - mac_chromium_10.10_rel_ng - mac_chromium_archive_rel_ng - mac_nacl_sdk - mac_nacl_sdk_build - mac_optional_gpu_tests_rel Leaving pretty much just the internal official builders, the memory/sanitizer builders, the angle trybots, and various fyi builders. R=rsesek@chromium.org BUG=618468 ========== to ========== Flip more Mac builders to GN. This flips the following builders to GN: - chromium - Mac - chromium.chrome - Google Chrome Mac - chromium.perf - Mac Builder - tryserver.chromium.mac - mac_chromium_10.10_rel_ng - mac_chromium_archive_rel_ng - mac_nacl_sdk - mac_nacl_sdk_build - mac_optional_gpu_tests_rel Leaving pretty much just the internal official builders, the memory/sanitizer builders, the angle trybots, and various fyi builders. R=rsesek@chromium.org BUG=618468 Committed: https://crrev.com/edf8327a75981f91e292a8eeca4fef7aa2a942a3 Cr-Commit-Position: refs/heads/master@{#401288} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/edf8327a75981f91e292a8eeca4fef7aa2a942a3 Cr-Commit-Position: refs/heads/master@{#401288} |
