Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2089953002:
Remove client.skia section from mb_config.pyl (Closed)
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago Reviewers:
borenet CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_win_clang Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove client.skia section from mb_config.pyl.
The builders were removed so this section was useless.
TBR=borenet@google.com
BUG=618468, 605318
Committed: https://crrev.com/64cecdda60c559f9aa5dcdd7cb40e513bc0eab29
Cr-Commit-Position: refs/heads/master@{#401329}
Patch Set 1 #
Total comments: 1
Patch Set 2 : remove client.skia altogether #Messages
Total messages: 18 (8 generated)
Description was changed from ========== Flip remaining client.skia GYP builders to GN. There are very few remaining GYP builders downstream; the skia builders should be mirroring the GN builders now. R=borenet@chromium.org BUG=618468, 605318 ========== to ========== Flip remaining client.skia GYP builders to GN. There are very few remaining GYP builders downstream; the skia builders should be mirroring the GN builders now. R=borenet@google.com BUG=618468, 605318 ==========
dpranke@chromium.org changed reviewers: + borenet@google.com - borenet@chromium.org
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089953002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2089953002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2089953002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:531: 'Win Builder-Trybot': 'swarming_gpu_tests_gn_release_bot_x86', FTR, these bots no longer exist on the client.skia waterfall. Feel free to just remove this whole section.
On 2016/06/22 11:41:39, borenet wrote: > https://codereview.chromium.org/2089953002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2089953002/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:531: 'Win Builder-Trybot': > 'swarming_gpu_tests_gn_release_bot_x86', > FTR, these bots no longer exist on the client.skia waterfall. Feel free to just > remove this whole section. Done. My audit script was skipping client.skia, making this useless anyway :(. TBR'ing since the change is trivial now.
Description was changed from ========== Flip remaining client.skia GYP builders to GN. There are very few remaining GYP builders downstream; the skia builders should be mirroring the GN builders now. R=borenet@google.com BUG=618468, 605318 ========== to ========== Remove client.skia section from mb_config.pyl. The builders were removed so this section was useless. TBR=borenet@google.com BUG=618468, 605318 ==========
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089953002/20001
LGTM but I have no knowledge of or authority over the other bots in the change.
On 2016/06/22 16:35:22, borenet wrote: > LGTM but I have no knowledge of or authority over the other bots in the change. The only bots affected were on client.skia. The stuff deleted on lines 1683-1694 was only referenced from the skia bots.
Message was sent while issue was closed.
Description was changed from ========== Remove client.skia section from mb_config.pyl. The builders were removed so this section was useless. TBR=borenet@google.com BUG=618468, 605318 ========== to ========== Remove client.skia section from mb_config.pyl. The builders were removed so this section was useless. TBR=borenet@google.com BUG=618468, 605318 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove client.skia section from mb_config.pyl. The builders were removed so this section was useless. TBR=borenet@google.com BUG=618468, 605318 ========== to ========== Remove client.skia section from mb_config.pyl. The builders were removed so this section was useless. TBR=borenet@google.com BUG=618468, 605318 Committed: https://crrev.com/64cecdda60c559f9aa5dcdd7cb40e513bc0eab29 Cr-Commit-Position: refs/heads/master@{#401329} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/64cecdda60c559f9aa5dcdd7cb40e513bc0eab29 Cr-Commit-Position: refs/heads/master@{#401329} |
