Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2076663006: Subzero: Fix frame size for floating-point register out-args. (Closed)

Created:
4 years, 6 months ago by Jim Stichnoth
Modified:
4 years, 6 months ago
Reviewers:
Eric Holk, Karl, John, manasijm
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix frame size for floating-point register out-args. The code that calculates maximum out-arg stack space was neglecting the fact that on x86-64, the first N scalar floating-point arguments are passed through xmm registers, not the stack. As a result, stack frames were sometimes larger than necessary. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c577727f49d6f4ccdbf40e9fa527cf1c97f23a7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 6 months ago (2016-06-18 07:11:50 UTC) #3
John
lgtm
4 years, 6 months ago (2016-06-20 13:41:01 UTC) #4
Jim Stichnoth
4 years, 6 months ago (2016-06-20 13:46:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c577727f49d6f4ccdbf40e9fa527cf1c97f23a7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698