src/IceTargetLoweringX86BaseImpl.h - Issue 2076663006: Subzero: Fix frame size for floating-point register out-args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 2076663006: Subzero: Fix frame size for floating-point register out-args. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX86BaseImpl.h

diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h

index 3ed27cbb69a30ce31b43c4100b4241570821ef25..b3b65b391bc53bff09bcc5bb54ae60a35b39cc05 100644

--- a/src/IceTargetLoweringX86BaseImpl.h

+++ b/src/IceTargetLoweringX86BaseImpl.h

@@ -7019,6 +7019,9 @@ uint32_t TargetX86Base<TraitsType>::getCallStackArgumentsSizeBytes(

assert(typeWidthInBytes(Ty) >= 4);

if (isVectorType(Ty) && XmmArgCount < Traits::X86_MAX_XMM_ARGS) {

++XmmArgCount;

+ } else if (isScalarFloatingType(Ty) && Traits::X86_PASS_SCALAR_FP_IN_XMM &&

+ XmmArgCount < Traits::X86_MAX_XMM_ARGS) {

+ ++XmmArgCount;

} else if (isScalarIntegerType(Ty) &&

GprArgCount < Traits::X86_MAX_GPR_ARGS) {

// The 64 bit ABI allows some integers to be passed in GPRs.

« no previous file with comments | « no previous file | no next file » | no next file with comments »