Remove calls to MessageLoop::current() in media.

Remove calls to MessageLoop::current() in media.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=chcunningham@chromium.org

Committed: https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954
Cr-Commit-Position: refs/heads/master@{#402911}

[chcunningham, 2016-06-21 01:34:36]

Looks good, but I'll take another pass after you rebase

https://codereview.chromium.org/2076423004/diff/1/media/audio/audio_device_th...
File media/audio/audio_device_thread.cc (right):

https://codereview.chromium.org/2076423004/diff/1/media/audio/audio_device_th...
media/audio/audio_device_thread.cc:47: void
Stop(scoped_refptr<base::SingleThreadTaskRunner> task_runner_for_join);
This file just underwent some significant cleanup that got merged before you.
See
https://chromium.googlesource.com/chromium/src/+/47f99faeb277c3fbd9eb709f803c...

https://codereview.chromium.org/2076423004/diff/1/media/base/test_helpers.cc
File media/base/test_helpers.cc (right):

https://codereview.chromium.org/2076423004/diff/1/media/base/test_helpers.cc#...
media/base/test_helpers.cc:73: DCHECK(!!task_runner_);
Is the !! needed?

[chcunningham, 2016-06-21 21:29:59]

Bots are sad about some syntax errors. I found 2, but there may be more

https://codereview.chromium.org/2076423004/diff/40001/media/audio/sounds/test...
File media/audio/sounds/test_data.cc (right):

https://codereview.chromium.org/2076423004/diff/40001/media/audio/sounds/test...
media/audio/sounds/test_data.cc:17: DCHECK(loop_);
Delete this one.

https://codereview.chromium.org/2076423004/diff/40001/media/gpu/vaapi_video_d...
File media/gpu/vaapi_video_decode_accelerator.cc (right):

https://codereview.chromium.org/2076423004/diff/40001/media/gpu/vaapi_video_d...
media/gpu/vaapi_video_decode_accelerator.cc:397:
DCHECK(task_runner_->BelongsToCurrentThread())
Missing semicolons

[fdoray, 2016-06-29 15:44:31]

PTAnL

https://codereview.chromium.org/2076423004/diff/1/media/audio/audio_device_th...
File media/audio/audio_device_thread.cc (right):

https://codereview.chromium.org/2076423004/diff/1/media/audio/audio_device_th...
media/audio/audio_device_thread.cc:47: void
Stop(scoped_refptr<base::SingleThreadTaskRunner> task_runner_for_join);
On 2016/06/21 01:34:36, chcunningham wrote:
> This file just underwent some significant cleanup that got merged before you.
> See
>
https://chromium.googlesource.com/chromium/src/+/47f99faeb277c3fbd9eb709f803c...

Done.

https://codereview.chromium.org/2076423004/diff/1/media/base/test_helpers.cc
File media/base/test_helpers.cc (right):

https://codereview.chromium.org/2076423004/diff/1/media/base/test_helpers.cc#...
media/base/test_helpers.cc:73: DCHECK(!!task_runner_);
On 2016/06/21 01:34:36, chcunningham wrote:
> Is the !! needed?

no, removed it

https://codereview.chromium.org/2076423004/diff/40001/media/audio/sounds/test...
File media/audio/sounds/test_data.cc (right):

https://codereview.chromium.org/2076423004/diff/40001/media/audio/sounds/test...
media/audio/sounds/test_data.cc:17: DCHECK(loop_);
On 2016/06/21 21:29:59, chcunningham wrote:
> Delete this one.

Done.

https://codereview.chromium.org/2076423004/diff/40001/media/gpu/vaapi_video_d...
File media/gpu/vaapi_video_decode_accelerator.cc (right):

https://codereview.chromium.org/2076423004/diff/40001/media/gpu/vaapi_video_d...
media/gpu/vaapi_video_decode_accelerator.cc:397:
DCHECK(task_runner_->BelongsToCurrentThread())
On 2016/06/21 21:29:59, chcunningham wrote:
> Missing semicolons

Done.

[chcunningham, 2016-06-29 18:10:05]

lgtm % nits

https://codereview.chromium.org/2076423004/diff/80001/media/base/test_helpers.cc
File media/base/test_helpers.cc (right):

https://codereview.chromium.org/2076423004/diff/80001/media/base/test_helpers...
media/base/test_helpers.cc:70: DCHECK(CalledOnValidThread());
This is sort of tautological right? Thread checker was just constructed on this
thread, so its definitely going to be valid.

https://codereview.chromium.org/2076423004/diff/80001/media/gpu/v4l2_video_de...
File media/gpu/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/2076423004/diff/80001/media/gpu/v4l2_video_de...
media/gpu/v4l2_video_decode_accelerator.cc:1725: if
(decoder_thread_.task_runner() &&
Is there any chance of a null task runner on a thread? We're not null checking
elsewhere

https://codereview.chromium.org/2076423004/diff/80001/media/gpu/v4l2_video_en...
File media/gpu/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/2076423004/diff/80001/media/gpu/v4l2_video_en...
media/gpu/v4l2_video_encode_accelerator.cc:876: if (task_runner &&
!task_runner->BelongsToCurrentThread()) {
ditto about the null check. why here and not elsewhere

[fdoray, 2016-06-29 18:20:18]

https://codereview.chromium.org/2076423004/diff/80001/media/base/test_helpers.cc
File media/base/test_helpers.cc (right):

https://codereview.chromium.org/2076423004/diff/80001/media/base/test_helpers...
media/base/test_helpers.cc:70: DCHECK(CalledOnValidThread());
On 2016/06/29 18:10:04, chcunningham wrote:
> This is sort of tautological right? Thread checker was just constructed on
this
> thread, so its definitely going to be valid.

Done. Removed it, you're right.

https://codereview.chromium.org/2076423004/diff/80001/media/gpu/v4l2_video_de...
File media/gpu/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/2076423004/diff/80001/media/gpu/v4l2_video_de...
media/gpu/v4l2_video_decode_accelerator.cc:1725: if
(decoder_thread_.task_runner() &&
On 2016/06/29 18:10:04, chcunningham wrote:
> Is there any chance of a null task runner on a thread? We're not null checking
> elsewhere

TaskRunner can be null before the thread has been started and after it has been
stopped. I guess this check is here because SetErrorState can be called in these
contexts.

https://codereview.chromium.org/2076423004/diff/80001/media/gpu/v4l2_video_en...
File media/gpu/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/2076423004/diff/80001/media/gpu/v4l2_video_en...
media/gpu/v4l2_video_encode_accelerator.cc:876: if (task_runner &&
!task_runner->BelongsToCurrentThread()) {
On 2016/06/29 18:10:04, chcunningham wrote:
> ditto about the null check. why here and not elsewhere

ditto

[fdoray, 2016-06-29 18:20:47]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-06-29 18:20:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
chcunningham@chromium.org
Link to the patchset: https://codereview.chromium.org/2076423004/#ps100001
(title: "CR")

[commit-bot: I haz the power, 2016-06-29 18:22:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 19:53:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-29 19:54:45]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 19:55:00]

Description was changed from

==========
Remove calls to MessageLoop::current() in media.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=chcunningham@chromium.org
==========

to

==========
Remove calls to MessageLoop::current() in media.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=chcunningham@chromium.org

Committed: https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954
Cr-Commit-Position: refs/heads/master@{#402911}
==========

[commit-bot: I haz the power, 2016-06-29 19:55:01]

Patchset 6 (id:??) landed as
https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954
Cr-Commit-Position: refs/heads/master@{#402911}