Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: media/base/test_helpers.cc

Issue 2076423004: Remove calls to MessageLoop::current() in media. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/test_helpers.h ('k') | media/capture/video/file_video_capture_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/test_helpers.cc
diff --git a/media/base/test_helpers.cc b/media/base/test_helpers.cc
index 60581554ea797e0e54c71e4f952e7374ca74cf49..c532f16c0c4788c8095784a2800515f773672fa6 100644
--- a/media/base/test_helpers.cc
+++ b/media/base/test_helpers.cc
@@ -9,7 +9,6 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/macros.h"
-#include "base/message_loop/message_loop.h"
#include "base/pickle.h"
#include "base/run_loop.h"
#include "base/test/test_timeouts.h"
@@ -67,34 +66,32 @@ WaitableMessageLoopEvent::WaitableMessageLoopEvent()
: WaitableMessageLoopEvent(TestTimeouts::action_timeout()) {}
WaitableMessageLoopEvent::WaitableMessageLoopEvent(base::TimeDelta timeout)
- : message_loop_(base::MessageLoop::current()),
- signaled_(false),
- status_(PIPELINE_OK),
- timeout_(timeout) {
- DCHECK(message_loop_);
-}
+ : signaled_(false), status_(PIPELINE_OK), timeout_(timeout) {}
-WaitableMessageLoopEvent::~WaitableMessageLoopEvent() {}
+WaitableMessageLoopEvent::~WaitableMessageLoopEvent() {
+ DCHECK(CalledOnValidThread());
+}
base::Closure WaitableMessageLoopEvent::GetClosure() {
- DCHECK_EQ(message_loop_, base::MessageLoop::current());
+ DCHECK(CalledOnValidThread());
return BindToCurrentLoop(base::Bind(
&WaitableMessageLoopEvent::OnCallback, base::Unretained(this),
PIPELINE_OK));
}
PipelineStatusCB WaitableMessageLoopEvent::GetPipelineStatusCB() {
- DCHECK_EQ(message_loop_, base::MessageLoop::current());
+ DCHECK(CalledOnValidThread());
return BindToCurrentLoop(base::Bind(
&WaitableMessageLoopEvent::OnCallback, base::Unretained(this)));
}
void WaitableMessageLoopEvent::RunAndWait() {
+ DCHECK(CalledOnValidThread());
RunAndWaitForStatus(PIPELINE_OK);
}
void WaitableMessageLoopEvent::RunAndWaitForStatus(PipelineStatus expected) {
- DCHECK_EQ(message_loop_, base::MessageLoop::current());
+ DCHECK(CalledOnValidThread());
if (signaled_) {
EXPECT_EQ(expected, status_);
return;
@@ -113,7 +110,7 @@ void WaitableMessageLoopEvent::RunAndWaitForStatus(PipelineStatus expected) {
}
void WaitableMessageLoopEvent::OnCallback(PipelineStatus status) {
- DCHECK_EQ(message_loop_, base::MessageLoop::current());
+ DCHECK(CalledOnValidThread());
signaled_ = true;
status_ = status;
@@ -123,7 +120,7 @@ void WaitableMessageLoopEvent::OnCallback(PipelineStatus status) {
}
void WaitableMessageLoopEvent::OnTimeout() {
- DCHECK_EQ(message_loop_, base::MessageLoop::current());
+ DCHECK(CalledOnValidThread());
ADD_FAILURE() << "Timed out waiting for message loop to quit";
run_loop_->Quit();
}
« no previous file with comments | « media/base/test_helpers.h ('k') | media/capture/video/file_video_capture_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698