Flip most other CrOS builders to GN.

Flip most other CrOS builders to GN.

R=stevenjb@chromium.org
BUG=433082
Committed: https://crrev.com/4f4d7223e6b66fccaec0047bdd39c338b1e70069
Cr-Commit-Position: refs/heads/master@{#401204}

[Dirk Pranke, 2016-06-19 01:47:46]

dpranke@chromium.org changed reviewers:
+ jmadill@chromium.org

[Dirk Pranke, 2016-06-19 01:47:47]

@jmadill - for the angle bot config change.

@stevenjb - for everything else.

https://codereview.chromium.org/2076393002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2076393002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:1530: 'swarming', 'chromeos', 'msan', 'gn',
'release_bot',
this changes from _trybot to _bot because the _trybot config (which enables
DCHECKS) is generically broken w/ msan (it's broken in GYP as well).

[Jamie Madill, 2016-06-19 02:09:47]

Description was changed from

==========
Flip most other CrOS builders to GN.

R=stevenjb@chromium.org
BUG=433082
==========

to

==========
Flip most other CrOS builders to GN.

R=stevenjb@chromium.org
BUG=433082
==========

[Jamie Madill, 2016-06-19 02:11:45]

I think the ANGLE ChromeOS bot support is dependent on
https://chromium-review.googlesource.com/#/c/352251/.. we'll have to wait until
that's landed before flipping the ANGLE bot.

Frank do you know when that might be ready?

[Dirk Pranke, 2016-06-20 23:43:26]

stevenjb, fjhenigman - ping?

[stevenjb, 2016-06-21 00:16:22]

I'm not really familiar with mb, but gyp -> gn for linux chromeos lgtm !

[fjhenigman, 2016-06-21 03:05:01]

On 2016/06/19 02:11:45, Jamie Madill wrote:
> I think the ANGLE ChromeOS bot support is dependent on
> https://chromium-review.googlesource.com/#/c/352251/.. we'll have to wait
until
> that's landed before flipping the ANGLE bot.
> 
> Frank do you know when that might be ready?

It needs a bit more work and testing, but is it actually blocking anything?
All it does is add a few files to the use_ozone=1 case, and as far as I can tell
no existing gyp builder compiles those files, so switching them to gn should
change nothing?

[Jamie Madill, 2016-06-21 12:48:15]

On 2016/06/21 03:05:01, fjhenigman wrote:
> On 2016/06/19 02:11:45, Jamie Madill wrote:
> > I think the ANGLE ChromeOS bot support is dependent on
> > https://chromium-review.googlesource.com/#/c/352251/.. we'll have to wait
> until
> > that's landed before flipping the ANGLE bot.
> > 
> > Frank do you know when that might be ready?
> 
> It needs a bit more work and testing, but is it actually blocking anything?
> All it does is add a few files to the use_ozone=1 case, and as far as I can
tell
> no existing gyp builder compiles those files, so switching them to gn should
> change nothing?

Alright, lgtm then. I guess I don't know what the bot compiles.

[Dirk Pranke, 2016-06-21 22:40:03]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 22:40:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076393002/40001

[commit-bot: I haz the power, 2016-06-22 02:12:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 02:12:35]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-06-22 04:03:40]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-06-22 04:03:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, jmadill@chromium.org
Link to the patchset: https://codereview.chromium.org/2076393002/#ps40001
(title: "merge again, fix dependent patchset")

[commit-bot: I haz the power, 2016-06-22 04:03:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076393002/40001

[commit-bot: I haz the power, 2016-06-22 04:07:56]

Description was changed from

==========
Flip most other CrOS builders to GN.

R=stevenjb@chromium.org
BUG=433082
==========

to

==========
Flip most other CrOS builders to GN.

R=stevenjb@chromium.org
BUG=433082
==========

[commit-bot: I haz the power, 2016-06-22 04:07:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-22 04:10:40]

Description was changed from

==========
Flip most other CrOS builders to GN.

R=stevenjb@chromium.org
BUG=433082
==========

to

==========
Flip most other CrOS builders to GN.

R=stevenjb@chromium.org
BUG=433082

Committed: https://crrev.com/4f4d7223e6b66fccaec0047bdd39c338b1e70069
Cr-Commit-Position: refs/heads/master@{#401204}
==========

[commit-bot: I haz the power, 2016-06-22 04:10:41]

Patchset 3 (id:??) landed as
https://crrev.com/4f4d7223e6b66fccaec0047bdd39c338b1e70069
Cr-Commit-Position: refs/heads/master@{#401204}