Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2083163002:
update definitions for android_angle_rel_ng (Closed)
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionupdate definitions for android_angle_rel_ng in mb_config.pyl.
Updating since I guessed wrong at what they should be in r400711.
TBR=jmadill@chromium.org, kbr@chromium.org
Committed: https://crrev.com/5801b9a7982695429b8cb6a12e5a86893c63f642
Cr-Commit-Position: refs/heads/master@{#401178}
Patch Set 1 #
Total comments: 3
Dependent Patchsets: Messages
Total messages: 19 (7 generated)
Description was changed from ========== update definitions for android_angle_rel_ng in mb_config.pyl. Updating since I guessed wrong at what they should be in r400711. TBR=jmadill@chromium.org ========== to ========== update definitions for android_angle_rel_ng in mb_config.pyl. Updating since I guessed wrong at what they should be in r400711. TBR=jmadill@chromium.org, kbr@chromium.org ==========
dpranke@chromium.org changed reviewers: + kbr@chromium.org
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083163002/1
lgtm
https://codereview.chromium.org/2083163002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2083163002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:1614: 'swarming_gpu_tests_android_gn_release_trybot': [ lgtm, although I think most of the other angle trybots still say 'fyi'
https://codereview.chromium.org/2083163002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2083163002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:1614: 'swarming_gpu_tests_android_gn_release_trybot': [ On 2016/06/21 21:56:22, Jamie Madill wrote: > lgtm, although I think most of the other angle trybots still say 'fyi' That's because they're actually enabling internal_gles2_conform_tests and angle_deqp_tests. If you want to change that, we can do so.
https://codereview.chromium.org/2083163002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2083163002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:1614: 'swarming_gpu_tests_android_gn_release_trybot': [ On 2016/06/21 22:07:48, Dirk Pranke wrote: > On 2016/06/21 21:56:22, Jamie Madill wrote: > > lgtm, although I think most of the other angle trybots still say 'fyi' > > That's because they're actually enabling internal_gles2_conform_tests and > angle_deqp_tests. If you want to change that, we can do so. I believe the fyi-ness just means which waterfall they're on rather than the set of tests they're running. ken can confirm. still lgtm though as it is now, if necessary we can change the name when we add those other tests.
On 2016/06/21 22:10:47, Jamie Madill wrote: > https://codereview.chromium.org/2083163002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2083163002/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:1614: 'swarming_gpu_tests_android_gn_release_trybot': [ > On 2016/06/21 22:07:48, Dirk Pranke wrote: > > On 2016/06/21 21:56:22, Jamie Madill wrote: > > > lgtm, although I think most of the other angle trybots still say 'fyi' > > > > That's because they're actually enabling internal_gles2_conform_tests and > > angle_deqp_tests. If you want to change that, we can do so. > > I believe the fyi-ness just means which waterfall they're on rather than the set > of tests they're running. ken can confirm. still lgtm though as it is now, if > necessary we can change the name when we add those other tests. Dirk's correct; the "fyi" aspect of these MB configs is related more to which tests they run.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
On 2016/06/22 00:55:58, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) Lack of GPU bot capacity. http://crbug.com/614526 . Trying again.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083163002/1
Message was sent while issue was closed.
Description was changed from ========== update definitions for android_angle_rel_ng in mb_config.pyl. Updating since I guessed wrong at what they should be in r400711. TBR=jmadill@chromium.org, kbr@chromium.org ========== to ========== update definitions for android_angle_rel_ng in mb_config.pyl. Updating since I guessed wrong at what they should be in r400711. TBR=jmadill@chromium.org, kbr@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== update definitions for android_angle_rel_ng in mb_config.pyl. Updating since I guessed wrong at what they should be in r400711. TBR=jmadill@chromium.org, kbr@chromium.org ========== to ========== update definitions for android_angle_rel_ng in mb_config.pyl. Updating since I guessed wrong at what they should be in r400711. TBR=jmadill@chromium.org, kbr@chromium.org Committed: https://crrev.com/5801b9a7982695429b8cb6a12e5a86893c63f642 Cr-Commit-Position: refs/heads/master@{#401178} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5801b9a7982695429b8cb6a12e5a86893c63f642 Cr-Commit-Position: refs/heads/master@{#401178} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
