chrome/browser/external_protocol/external_protocol_handler.h - Issue 2076253002: Simplify the text in the external protocol confirmation dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_protocol/external_protocol_handler.h

Issue 2076253002: Simplify the text in the external protocol confirmation dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update based on UI review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/external_protocol_dialog.cc ('k') | chrome/browser/external_protocol/external_protocol_handler.cc » ('j') | chrome/browser/external_protocol/external_protocol_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_protocol/external_protocol_handler.h

diff --git a/chrome/browser/external_protocol/external_protocol_handler.h b/chrome/browser/external_protocol/external_protocol_handler.h

index 692f2dda0aa88bd2669ad77f4d954617cac66d47..a3b3d97731549dc410b8db17a79cd7107db74f8a 100644

--- a/chrome/browser/external_protocol/external_protocol_handler.h

+++ b/chrome/browser/external_protocol/external_protocol_handler.h

@@ -46,6 +46,9 @@ class ExternalProtocolHandler {

virtual ~Delegate() {}

};

+ // Histogram name for whether the remember checkbox is checked.

+ static const char kRememberCheckedHistogram[];

// Returns whether we should block a given scheme.

static BlockState GetBlockState(const std::string& scheme);