Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: chrome/browser/external_protocol/external_protocol_handler.cc

Issue 2076253002: Simplify the text in the external protocol confirmation dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update based on UI review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_protocol/external_protocol_handler.cc
diff --git a/chrome/browser/external_protocol/external_protocol_handler.cc b/chrome/browser/external_protocol/external_protocol_handler.cc
index 540ffbafe93572eab5b343b4c2dabcd895ca1907..70ea49533d3c675ab2f6eeffc4f7e1d1efb678f4 100644
--- a/chrome/browser/external_protocol/external_protocol_handler.cc
+++ b/chrome/browser/external_protocol/external_protocol_handler.cc
@@ -131,6 +131,10 @@ void OnDefaultProtocolClientWorkerFinished(
} // namespace
// static
+const char ExternalProtocolHandler::kRememberCheckedHistogram[] =
+ "ExternalProtocolDialog.RememberCheckbox";
meacer 2016/10/04 01:28:56 I think it'll be nicer if the UMA code was moved h
dominickn 2016/10/04 12:37:01 Done.
+
+// static
void ExternalProtocolHandler::PrepopulateDictionary(
base::DictionaryValue* win_pref) {
static bool is_warm = false;

Powered by Google App Engine
This is Rietveld 408576698