Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: chrome/browser/external_protocol/external_protocol_handler.h

Issue 2076253002: Simplify the text in the external protocol confirmation dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update based on UI review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTERNAL_PROTOCOL_EXTERNAL_PROTOCOL_HANDLER_H_ 5 #ifndef CHROME_BROWSER_EXTERNAL_PROTOCOL_EXTERNAL_PROTOCOL_HANDLER_H_
6 #define CHROME_BROWSER_EXTERNAL_PROTOCOL_EXTERNAL_PROTOCOL_HANDLER_H_ 6 #define CHROME_BROWSER_EXTERNAL_PROTOCOL_EXTERNAL_PROTOCOL_HANDLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 28 matching lines...) Expand all
39 const GURL& url, 39 const GURL& url,
40 int render_process_host_id, 40 int render_process_host_id,
41 int routing_id, 41 int routing_id,
42 ui::PageTransition page_transition, 42 ui::PageTransition page_transition,
43 bool has_user_gesture) = 0; 43 bool has_user_gesture) = 0;
44 virtual void LaunchUrlWithoutSecurityCheck(const GURL& url) = 0; 44 virtual void LaunchUrlWithoutSecurityCheck(const GURL& url) = 0;
45 virtual void FinishedProcessingCheck() = 0; 45 virtual void FinishedProcessingCheck() = 0;
46 virtual ~Delegate() {} 46 virtual ~Delegate() {}
47 }; 47 };
48 48
49 // Histogram name for whether the remember checkbox is checked.
50 static const char kRememberCheckedHistogram[];
51
49 // Returns whether we should block a given scheme. 52 // Returns whether we should block a given scheme.
50 static BlockState GetBlockState(const std::string& scheme); 53 static BlockState GetBlockState(const std::string& scheme);
51 54
52 // Sets whether we should block a given scheme. 55 // Sets whether we should block a given scheme.
53 static void SetBlockState(const std::string& scheme, BlockState state); 56 static void SetBlockState(const std::string& scheme, BlockState state);
54 57
55 // Checks to see if the protocol is allowed, if it is whitelisted, 58 // Checks to see if the protocol is allowed, if it is whitelisted,
56 // the application associated with the protocol is launched on the io thread, 59 // the application associated with the protocol is launched on the io thread,
57 // if it is blacklisted, returns silently. Otherwise, an 60 // if it is blacklisted, returns silently. Otherwise, an
58 // ExternalProtocolDialog is created asking the user. If the user accepts, 61 // ExternalProtocolDialog is created asking the user. If the user accepts,
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 // This is typically triggered by a user gesture, but is also called for 109 // This is typically triggered by a user gesture, but is also called for
107 // each extension API function. Note that each call to LaunchUrl resets 110 // each extension API function. Note that each call to LaunchUrl resets
108 // the state to false (not allowed). 111 // the state to false (not allowed).
109 static void PermitLaunchUrl(); 112 static void PermitLaunchUrl();
110 113
111 private: 114 private:
112 DISALLOW_COPY_AND_ASSIGN(ExternalProtocolHandler); 115 DISALLOW_COPY_AND_ASSIGN(ExternalProtocolHandler);
113 }; 116 };
114 117
115 #endif // CHROME_BROWSER_EXTERNAL_PROTOCOL_EXTERNAL_PROTOCOL_HANDLER_H_ 118 #endif // CHROME_BROWSER_EXTERNAL_PROTOCOL_EXTERNAL_PROTOCOL_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698