Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2076053002: [mb] Add presubmit checks (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mb] Add presubmit checks Also comment out some currently unused configs the presubmit check now complains about. They'll be used soon, once respective bots are added. BUG=chromium:616035 TBR=kjellander@chromium.org NOTRY=true Committed: https://crrev.com/3249e23e5a8b2eb56a1178d1b128defce465fcc5 Cr-Commit-Position: refs/heads/master@{#37056}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -8 lines) Patch
A infra/mb/PRESUBMIT.py View 1 chunk +35 lines, -0 lines 2 comments Download
M infra/mb/mb_config.pyl View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2076053002/diff/1/infra/mb/PRESUBMIT.py File infra/mb/PRESUBMIT.py (right): https://codereview.chromium.org/2076053002/diff/1/infra/mb/PRESUBMIT.py#newcode1 infra/mb/PRESUBMIT.py:1: # Copyright 2016 the V8 project authors. All ...
4 years, 6 months ago (2016-06-17 08:23:08 UTC) #4
kjellander_chromium
lgtm https://codereview.chromium.org/2076053002/diff/1/infra/mb/PRESUBMIT.py File infra/mb/PRESUBMIT.py (right): https://codereview.chromium.org/2076053002/diff/1/infra/mb/PRESUBMIT.py#newcode1 infra/mb/PRESUBMIT.py:1: # Copyright 2016 the V8 project authors. All ...
4 years, 6 months ago (2016-06-17 08:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076053002/1
4 years, 6 months ago (2016-06-17 08:26:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 08:34:52 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 08:35:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3249e23e5a8b2eb56a1178d1b128defce465fcc5
Cr-Commit-Position: refs/heads/master@{#37056}

Powered by Google App Engine
This is Rietveld 408576698