Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: infra/mb/PRESUBMIT.py

Issue 2076053002: [mb] Add presubmit checks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/mb/PRESUBMIT.py
diff --git a/infra/mb/PRESUBMIT.py b/infra/mb/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..39d15e80b43ff3b1036bd1742ef69033836b3b89
--- /dev/null
+++ b/infra/mb/PRESUBMIT.py
@@ -0,0 +1,35 @@
+# Copyright 2016 the V8 project authors. All rights reserved.
Michael Achenbach 2016/06/17 08:23:07 Shamelessly copied from webrtc. Thanks for the hin
kjellander_chromium 2016/06/17 08:25:21 Happy to help! It has caught several errors I've m
+# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+#
+# Use of this source code is governed by a BSD-style license
+# that can be found in the LICENSE file in the root of the source
+# tree. An additional intellectual property rights grant can be found
+# in the file PATENTS. All contributing project authors may
+# be found in the AUTHORS file in the root of the source tree.
+
+
+def _CommonChecks(input_api, output_api):
+ results = []
+
+ # Validate the format of the mb_config.pyl file.
+ mb_script = input_api.os_path.join(input_api.PresubmitLocalPath(), '..',
+ '..', 'tools', 'mb', 'mb.py')
+ mb_config_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
+ 'mb_config.pyl')
+ cmd = [input_api.python_executable, mb_script, 'validate', '--config-file',
+ mb_config_path]
+ kwargs = {'cwd': input_api.PresubmitLocalPath()}
+ results.extend(input_api.RunTests([
+ input_api.Command(name='mb_validate',
+ cmd=cmd, kwargs=kwargs,
+ message=output_api.PresubmitError)]))
+
+ return results
+
+
+def CheckChangeOnUpload(input_api, output_api):
+ return _CommonChecks(input_api, output_api)
+
+
+def CheckChangeOnCommit(input_api, output_api):
+ return _CommonChecks(input_api, output_api)
« no previous file with comments | « no previous file | infra/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698