Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: infra/mb/PRESUBMIT.py

Issue 2076053002: [mb] Add presubmit checks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | infra/mb/mb_config.pyl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright 2016 the V8 project authors. All rights reserved.
Michael Achenbach 2016/06/17 08:23:07 Shamelessly copied from webrtc. Thanks for the hin
kjellander_chromium 2016/06/17 08:25:21 Happy to help! It has caught several errors I've m
2 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 #
4 # Use of this source code is governed by a BSD-style license
5 # that can be found in the LICENSE file in the root of the source
6 # tree. An additional intellectual property rights grant can be found
7 # in the file PATENTS. All contributing project authors may
8 # be found in the AUTHORS file in the root of the source tree.
9
10
11 def _CommonChecks(input_api, output_api):
12 results = []
13
14 # Validate the format of the mb_config.pyl file.
15 mb_script = input_api.os_path.join(input_api.PresubmitLocalPath(), '..',
16 '..', 'tools', 'mb', 'mb.py')
17 mb_config_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
18 'mb_config.pyl')
19 cmd = [input_api.python_executable, mb_script, 'validate', '--config-file',
20 mb_config_path]
21 kwargs = {'cwd': input_api.PresubmitLocalPath()}
22 results.extend(input_api.RunTests([
23 input_api.Command(name='mb_validate',
24 cmd=cmd, kwargs=kwargs,
25 message=output_api.PresubmitError)]))
26
27 return results
28
29
30 def CheckChangeOnUpload(input_api, output_api):
31 return _CommonChecks(input_api, output_api)
32
33
34 def CheckChangeOnCommit(input_api, output_api):
35 return _CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | infra/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698