Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2075853004: Implement SharedQuadStateList StructTraits (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
Reviewers:
ajuma, dcheng, sky, meacer
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement SharedQuadStateList StructTraits This serializes and deserializes SharedQuadStateList via an iterator as ListContainer does not support O(1) random access. BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/abbce962323ac5660a9622674ef862d8f0530fe4 Cr-Commit-Position: refs/heads/master@{#400695}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed sky's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -26 lines) Patch
M cc/ipc/quads.mojom View 1 chunk +1 line, -1 line 0 comments Download
M cc/ipc/quads.typemap View 1 chunk +7 lines, -2 lines 0 comments Download
M cc/ipc/shared_quad_state.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/ipc/shared_quad_state_struct_traits.h View 1 chunk +47 lines, -0 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 4 chunks +3 lines, -9 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_utils.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_utils.cc View 1 1 chunk +8 lines, -10 lines 0 comments Download
M components/mus/public/cpp/surfaces/tests/surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (14 generated)
Fady Samuel
+sky@ for mus and bitmap_uploader +dcheng for mojo ipc.
4 years, 6 months ago (2016-06-17 21:23:30 UTC) #3
Fady Samuel
+inferno@ for ipc since dcheng@ is OOO. Thanks!
4 years, 6 months ago (2016-06-17 21:29:22 UTC) #5
Fady Samuel
+meacer@ since inferno@ doesn't review IPC anymore.
4 years, 6 months ago (2016-06-17 21:35:38 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075853004/1
4 years, 6 months ago (2016-06-17 21:48:57 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 22:54:08 UTC) #11
sky
https://codereview.chromium.org/2075853004/diff/1/components/bitmap_uploader/bitmap_uploader.cc File components/bitmap_uploader/bitmap_uploader.cc (right): https://codereview.chromium.org/2075853004/diff/1/components/bitmap_uploader/bitmap_uploader.cc#newcode84 components/bitmap_uploader/bitmap_uploader.cc:84: pass->shared_quad_states.AllocateAndConstruct<cc::SharedQuadState>(); Who owns the return value? https://codereview.chromium.org/2075853004/diff/1/components/mus/public/cpp/surfaces/surfaces_utils.h File components/mus/public/cpp/surfaces/surfaces_utils.h ...
4 years, 6 months ago (2016-06-17 23:05:36 UTC) #12
meacer
IPC lgtm.
4 years, 6 months ago (2016-06-18 00:58:59 UTC) #13
Fady Samuel
PTAL Scott! Thanks. Looks like I need a cc OWNER for the typemap file which ...
4 years, 6 months ago (2016-06-18 01:27:51 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075853004/20001
4 years, 6 months ago (2016-06-18 11:32:09 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-18 12:23:25 UTC) #19
ajuma
On 2016/06/18 01:27:51, Fady Samuel wrote: > PTAL Scott! Thanks. > > Looks like I ...
4 years, 6 months ago (2016-06-20 13:38:02 UTC) #20
sky
LGTM
4 years, 6 months ago (2016-06-20 15:23:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075853004/20001
4 years, 6 months ago (2016-06-20 15:24:00 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/203308)
4 years, 6 months ago (2016-06-20 15:30:17 UTC) #26
dcheng
rs lgtm for mojom changes (hopefully the OWNERS fixes will land today)
4 years, 6 months ago (2016-06-20 15:36:19 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075853004/20001
4 years, 6 months ago (2016-06-20 15:37:42 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 16:16:46 UTC) #30
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 16:20:02 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/abbce962323ac5660a9622674ef862d8f0530fe4
Cr-Commit-Position: refs/heads/master@{#400695}

Powered by Google App Engine
This is Rietveld 408576698