Implement SharedQuadStateList StructTraits

components/bitmap_uploader/bitmap_uploader.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bitmap_uploader/bitmap_uploader.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 62 matching lines @@
   const gfx::Rect bounds(window_->bounds());
   cc::mojom::RenderPassPtr pass = mojo::CreateDefaultPass(1, bounds);
   mus::mojom::CompositorFramePtr frame = mus::mojom::CompositorFrame::New();
 
   // TODO(rjkroege): Support device scale factor in PDF viewer
   frame->metadata.device_scale_factor = 1.0f;
 
   frame->resources.resize(0u);
 
   pass->quads.resize(0u);
-  pass->shared_quad_states.push_back(mojo::CreateDefaultSQS(bounds.size()));
+  cc::SharedQuadState* sqs =
+      pass->shared_quad_states.AllocateAndConstruct<cc::SharedQuadState>();

[sky, 2016/06/17 23:05:36]

Who owns the return value?

[Fady Samuel, 2016/06/18 01:27:51]

Added a comment. It's owned by the shared_quad_states list.

+  mojo::CreateDefaultSQS(bounds.size(), sqs);
 
   if (bitmap_.get()) {
     gpu::gles2::GLES2Interface* gl = gles2_context_->interface();
     gfx::Size bitmap_size(width_, height_);
     GLuint texture_id = BindTextureForSize(bitmap_size);
     gl->TexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, bitmap_size.width(),
                       bitmap_size.height(), TextureFormat(), GL_UNSIGNED_BYTE,
                       &((*bitmap_)[0]));
 
     gpu::Mailbox mailbox;
@@ skipping 109 matching lines @@
     DCHECK_EQ(1, resource.count);
     gl->WaitSyncTokenCHROMIUM(resource.sync_token.GetConstData());
     uint32_t texture_id = resource_to_texture_id_map_[resource.id];
     DCHECK_NE(0u, texture_id);
     resource_to_texture_id_map_.erase(resource.id);
     gl->DeleteTextures(1, &texture_id);
   }
 }
 
 }  // namespace bitmap_uploader