Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment + TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index 9487ad0efc570d93c012fa1aabc3e0562174e63b..a4fc3bb968d5c28d812039d0be1b74a2ce1410f8 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -217,14 +217,14 @@ void PermissionContextBase::PermissionDecided(
content_setting == CONTENT_SETTING_BLOCK);
if (content_setting == CONTENT_SETTING_ALLOW)
PermissionUmaUtil::PermissionGranted(permission_type_, requesting_origin,
- profile_);
+ PROMPT, profile_);
raymes 2016/07/12 00:54:36 As discussed, I think in most cases we don't need
kcarattini 2016/07/12 01:01:42 I assume that we don't call it for anything but th
stefanocs 2016/07/12 04:33:33 Done.
else
PermissionUmaUtil::PermissionDenied(permission_type_, requesting_origin,
- profile_);
+ PROMPT, profile_);
} else {
DCHECK_EQ(content_setting, CONTENT_SETTING_DEFAULT);
PermissionUmaUtil::PermissionDismissed(permission_type_, requesting_origin,
- profile_);
+ PROMPT, profile_);
}
#endif

Powered by Google App Engine
This is Rietveld 408576698