Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6575)

Unified Diff: chrome/browser/permissions/permission_util.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment + TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_util.cc
diff --git a/chrome/browser/permissions/permission_util.cc b/chrome/browser/permissions/permission_util.cc
index 78271a2c5f2565088a25de0df504fb1a62f93719..8aa3da46b29008b4e8f95715a5ed1afe6469691a 100644
--- a/chrome/browser/permissions/permission_util.cc
+++ b/chrome/browser/permissions/permission_util.cc
@@ -100,8 +100,10 @@ void PermissionUtil::SetContentSettingAndRecordRevocation(
final_value != CONTENT_SETTING_ALLOW) {
PermissionType permission_type;
if (PermissionUtil::GetPermissionType(content_type, &permission_type)) {
+ // TODO(stefanocs): Report revocations from page action as PAGE_ACTION
+ // source UI instead of SITE_SETTINGS source UI.
kcarattini 2016/07/07 01:57:51 Is this complex enough to warrant a separate cl? L
stefanocs 2016/07/07 03:50:55 After chatting offline, this will be fixed in the
PermissionUmaUtil::PermissionRevoked(permission_type, primary_url,
- profile);
+ SITE_SETTINGS, profile);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698