chrome/browser/permissions/permission_bubble_request_impl.cc - Issue 2075523002: Add SourceUI field to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment + TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_bubble_request_impl.cc

diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc

index 832105d72951ec03dbb0ce4b9122b67be4b982d2..e93957a6cced92a6ada706ab1c7f6106a347d38f 100644

--- a/chrome/browser/permissions/permission_bubble_request_impl.cc

+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc

@@ -32,7 +32,7 @@ PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {

DCHECK(is_finished_);

if (!action_taken_)

PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_,

- profile_);

+ PROMPT, profile_);

}

gfx::VectorIconId PermissionBubbleRequestImpl::GetVectorIconId() const {