[turbofan] Properly mark the Check/Checked operators are pure.

src/compiler/simplified-operator.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/simplified-operator.h"
 
 #include "src/base/lazy-instance.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator.h"
 #include "src/types.h"
@@ skipping 284 matching lines @@
         : Operator(IrOpcode::k##Name, Operator::kPure | properties, #Name, \
                    input_count, 0, 0, 1, 0, 0) {}                          \
   };                                                                       \
   Name##Operator k##Name;
   PURE_OP_LIST(PURE)
 #undef PURE
 
 #define CHECKED(Name)                                                        \
   struct Name##Operator final : public Operator {                            \
     Name##Operator()                                                         \
-        : Operator(IrOpcode::k##Name, Operator::kNoThrow, #Name, 1, 1, 1, 1, \
-                   1, 0) {}                                                  \
+        : Operator(IrOpcode::k##Name, Operator::kPure, #Name, 1, 1, 1, 1, 1, \
+                   0) {}                                                     \
   };                                                                         \
   Name##Operator k##Name;
   CHECKED_OP_LIST(CHECKED)
 #undef CHECKED
 
   template <CheckFloat64HoleMode kMode>
   struct CheckFloat64HoleNaNOperatortor final
       : public Operator1<CheckFloat64HoleMode> {
     CheckFloat64HoleNaNOperatortor()
-        : Operator1<CheckFloat64HoleMode>(
-              IrOpcode::kCheckFloat64Hole, Operator::kFoldable,
-              "CheckFloat64Hole", 1, 1, 1, 1, 1, 0, kMode) {}
+        : Operator1<CheckFloat64HoleMode>(IrOpcode::kCheckFloat64Hole,
+                                          Operator::kPure, "CheckFloat64Hole",
+                                          1, 1, 1, 1, 1, 0, kMode) {}
   };
   CheckFloat64HoleNaNOperatortor<CheckFloat64HoleMode::kAllowReturnHole>
       kCheckFloat64HoleAllowReturnHoleOperator;
   CheckFloat64HoleNaNOperatortor<CheckFloat64HoleMode::kNeverReturnHole>
       kCheckFloat64HoleNeverReturnHoleOperator;
 
   template <CheckTaggedHoleMode kMode>
   struct CheckTaggedHoleOperator final : public Operator1<CheckTaggedHoleMode> {
     CheckTaggedHoleOperator()
         : Operator1<CheckTaggedHoleMode>(IrOpcode::kCheckTaggedHole,
-                                         Operator::kFoldable, "CheckTaggedHole",
-                                         1, 1, 1, 1, 1, 0, kMode) {}
+                                         Operator::kPure, "CheckTaggedHole", 1,
+                                         1, 1, 1, 1, 0, kMode) {}
   };
   CheckTaggedHoleOperator<CheckTaggedHoleMode::kConvertHoleToUndefined>
       kCheckTaggedHoleConvertHoleToUndefinedOperator;
   CheckTaggedHoleOperator<CheckTaggedHoleMode::kNeverReturnHole>
       kCheckTaggedHoleNeverReturnHoleOperator;
 
   struct CheckIfOperator final : public Operator {
     CheckIfOperator()
-        : Operator(IrOpcode::kCheckIf, Operator::kFoldable, "CheckIf", 1, 1, 1,
-                   0, 1, 0) {}
+        : Operator(IrOpcode::kCheckIf, Operator::kPure, "CheckIf", 1, 1, 1, 0,
+                   1, 0) {}
   };
   CheckIfOperator kCheckIf;
 
   template <PretenureFlag kPretenure>
   struct AllocateOperator final : public Operator1<PretenureFlag> {
     AllocateOperator()
         : Operator1<PretenureFlag>(IrOpcode::kAllocate, Operator::kNoThrow,
                                    "Allocate", 1, 1, 1, 1, 1, 0, kPretenure) {}
   };
   AllocateOperator<NOT_TENURED> kAllocateNotTenuredOperator;
@@ skipping 67 matching lines @@
 }
 
 const Operator* SimplifiedOperatorBuilder::ReferenceEqual(Type* type) {
   return new (zone()) Operator(IrOpcode::kReferenceEqual,
                                Operator::kCommutative | Operator::kPure,
                                "ReferenceEqual", 2, 0, 0, 1, 0, 0);
 }
 
 const Operator* SimplifiedOperatorBuilder::CheckBounds() {
   // TODO(bmeurer): Cache this operator. Make it pure!
-  return new (zone()) Operator(IrOpcode::kCheckBounds, Operator::kEliminatable,
+  return new (zone()) Operator(IrOpcode::kCheckBounds, Operator::kPure,
                                "CheckBounds", 2, 1, 1, 1, 1, 0);
 }
 
 const Operator* SimplifiedOperatorBuilder::TypeGuard(Type* type) {
   class TypeGuardOperator final : public Operator1<Type*> {
    public:
     explicit TypeGuardOperator(Type* type)
         : Operator1<Type*>(                           // --
               IrOpcode::kTypeGuard, Operator::kPure,  // opcode
               "TypeGuard",                            // name
@@ skipping 40 matching lines @@
     TYPED_ARRAYS(STORE_BUFFER)
 #undef STORE_BUFFER
   }
   UNREACHABLE();
   return nullptr;
 }
 
 const Operator* SimplifiedOperatorBuilder::SpeculativeNumberAdd(
     BinaryOperationHints::Hint hint) {
   return new (zone()) Operator1<BinaryOperationHints::Hint>(
-      IrOpcode::kSpeculativeNumberAdd, Operator::kNoThrow,
-      "SpeculativeNumberAdd", 2, 1, 1, 1, 1, 1, hint);
+      IrOpcode::kSpeculativeNumberAdd, Operator::kPure, "SpeculativeNumberAdd",
+      2, 1, 1, 1, 1, 1, hint);
 }
 
 const Operator* SimplifiedOperatorBuilder::SpeculativeNumberSubtract(
     BinaryOperationHints::Hint hint) {
   return new (zone()) Operator1<BinaryOperationHints::Hint>(
-      IrOpcode::kSpeculativeNumberSubtract, Operator::kNoThrow,
+      IrOpcode::kSpeculativeNumberSubtract, Operator::kPure,
       "SpeculativeNumberSubtract", 2, 1, 1, 1, 1, 1, hint);
 }
 
 #define ACCESS_OP_LIST(V)                                    \
   V(LoadField, FieldAccess, Operator::kNoWrite, 1, 1, 1)     \
   V(StoreField, FieldAccess, Operator::kNoRead, 2, 1, 0)     \
   V(LoadElement, ElementAccess, Operator::kNoWrite, 2, 1, 1) \
   V(StoreElement, ElementAccess, Operator::kNoRead, 3, 1, 0)
 
 
 #define ACCESS(Name, Type, properties, value_input_count, control_input_count, \
                output_count)                                                   \
   const Operator* SimplifiedOperatorBuilder::Name(const Type& access) {        \
     return new (zone())                                                        \
         Operator1<Type>(IrOpcode::k##Name, Operator::kNoThrow | properties,    \
                         #Name, value_input_count, 1, control_input_count,      \
                         output_count, 1, 0, access);                           \
   }
 ACCESS_OP_LIST(ACCESS)
 #undef ACCESS
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8