Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: appengine/findit/crash/test/findit_for_crash_test.py

Issue 2075153003: [Findit] Add fracas analysis result feedback page. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nits. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/findit_for_crash_test.py
diff --git a/appengine/findit/crash/test/findit_for_crash_test.py b/appengine/findit/crash/test/findit_for_crash_test.py
index d1d9bbba30bbdd17f4a058ab0ed5d6d022c544aa..f73e2be643b6d486ccd7acaea968362c652b8a66 100644
--- a/appengine/findit/crash/test/findit_for_crash_test.py
+++ b/appengine/findit/crash/test/findit_for_crash_test.py
@@ -311,8 +311,10 @@ class FinditForCrashTest(CrashTestSuite):
regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
'1', '2')}
- self.assertEqual(findit_for_crash.FindItForCrash(
- Stacktrace(), regression_deps_rolls, {}), expected_match_results)
+ results = findit_for_crash.FindItForCrash(Stacktrace(),
+ regression_deps_rolls, {})
+ self.assertEqual([result.ToDict() for result in results],
+ expected_match_results)
def testFinditForCrashFilterZeroConfidentResults(self):
def _MockFindMatchResults(*_):
@@ -355,14 +357,17 @@ class FinditForCrashTest(CrashTestSuite):
'url': 'https://repo.test/+/1',
'project_path': 'src/',
'review_url': 'https://codereview.chromium.org/3281',
- 'confidence': 0.8, 'revision': '1'},
+ 'confidence': 0.8, 'revision': '1'
+ },
]
regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
'1', '2')}
- self.assertEqual(findit_for_crash.FindItForCrash(
- Stacktrace(), regression_deps_rolls, {}), expected_match_results)
+ results = findit_for_crash.FindItForCrash(Stacktrace(),
+ regression_deps_rolls, {})
+ self.assertEqual([result.ToDict() for result in results],
+ expected_match_results)
def testFinditForCrashAllMatchResultsWithZeroConfidences(self):
def _MockFindMatchResults(*_):

Powered by Google App Engine
This is Rietveld 408576698