Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: appengine/findit/crash/fracas.py

Issue 2075153003: [Findit] Add fracas analysis result feedback page. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nits. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/fracas.py
diff --git a/appengine/findit/crash/fracas.py b/appengine/findit/crash/fracas.py
index c873e1f83b359fc3df80470846c8b1d6c1ea5434..441bd74256cdad9867e07ace5998fc5dc6a2628a 100644
--- a/appengine/findit/crash/fracas.py
+++ b/appengine/findit/crash/fracas.py
@@ -97,17 +97,19 @@ def FindCulpritForChromeCrash(signature, platform,
suspected_components = ComponentClassifier().Classify(
culprit_results, crash_stack)
+ culprit_results_json = [result.ToDict() for result in culprit_results]
+
return (
{
'found': (bool(suspected_project) or bool(suspected_components) or
- bool(culprit_results)),
+ bool(culprit_results_json)),
'regression_range': regression_versions,
'suspected_project': suspected_project,
'suspected_components': suspected_components,
- 'suspected_cls': culprit_results,
+ 'suspected_cls': culprit_results_json,
},
{
- 'found_suspects': bool(culprit_results),
+ 'found_suspects': bool(culprit_results_json),
'has_regression_range': bool(regression_versions),
'solution': 'core_algorithm',
}

Powered by Google App Engine
This is Rietveld 408576698