[Findit] Add fracas analysis result feedback page.

appengine/findit/crash/test/findit_for_crash_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 
 from common.blame import Region, Blame
 from common.change_log import ChangeLog
 from common.dependency import Dependency, DependencyRoll
 from common.git_repository import GitRepository
@@ skipping 293 matching lines @@
              'url': 'https://repo.test/+/1',
              'project_path': 'src/',
              'review_url': 'https://codereview.chromium.org/3281',
              'confidence': 1.0, 'revision': '1'
          },
     ]
 
     regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
                                                     '1', '2')}
 
-    self.assertEqual(findit_for_crash.FindItForCrash(
-        Stacktrace(), regression_deps_rolls, {}), expected_match_results)
+    results = findit_for_crash.FindItForCrash(Stacktrace(),
+                                              regression_deps_rolls, {})
+    self.assertEqual([result.ToDict() for result in results],
+                     expected_match_results)
 
   def testFinditForCrashFilterZeroConfidentResults(self):
     def _MockFindMatchResults(*_):
       match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
       match_result1.file_to_stack_infos = {
           'a.cc': [
               (StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
               (StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
           ]
       }
@@ skipping 22 matching lines @@
     expected_match_results = [
         {
             'reason': ('(1) Modified top crashing frame is #0\n'
                        '(2) Modification distance (LOC) is 1\n\n'
                        'Changed file a.cc crashed in frame #0, frame #1'),
             'time': 'Thu Mar 31 21:24:43 2016',
             'author': 'r@chromium.org',
             'url': 'https://repo.test/+/1',
             'project_path': 'src/',
             'review_url': 'https://codereview.chromium.org/3281',
-            'confidence': 0.8, 'revision': '1'},
+            'confidence': 0.8, 'revision': '1'
+        },
     ]
 
     regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
                                                     '1', '2')}
 
-    self.assertEqual(findit_for_crash.FindItForCrash(
-        Stacktrace(), regression_deps_rolls, {}), expected_match_results)
+    results = findit_for_crash.FindItForCrash(Stacktrace(),
+                                              regression_deps_rolls, {})
+    self.assertEqual([result.ToDict() for result in results],
+                     expected_match_results)
 
   def testFinditForCrashAllMatchResultsWithZeroConfidences(self):
     def _MockFindMatchResults(*_):
       match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
       match_result1.file_to_stack_infos = {
           'a.cc': [
               (StackFrame(20, 'src/', '', 'func', 'a.cc', [1]), 0),
               (StackFrame(21, 'src/', '', 'func', 'a.cc', [7]), 0),
           ]
       }
       match_result1.min_distance = 1
 
       match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
       match_result2.file_to_stack_infos = {
           'f.cc': [
               (StackFrame(15, 'src/', '', 'func', 'f.cc', [1]), 0),
           ]
       }
       match_result2.min_distance = 20
 
       return [match_result1, match_result2], {}
 
     self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
 
     regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
                                                     '1', '2')}
 
     self.assertEqual(findit_for_crash.FindItForCrash(
         Stacktrace(), regression_deps_rolls, {}), [])