Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2956)

Unified Diff: ash/keyboard/keyboard_ui.cc

Issue 2074913005: Convert TrayAccessibility to wm common types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webnotification
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/keyboard/keyboard_ui.cc
diff --git a/ash/keyboard/keyboard_ui.cc b/ash/keyboard/keyboard_ui.cc
index a9cb70c8ddb8d2a89c6291d2780693d35ef31a93..7022b9cfa19a0e6b9d851f0b1e0e2897197f48b5 100644
--- a/ash/keyboard/keyboard_ui.cc
+++ b/ash/keyboard/keyboard_ui.cc
@@ -5,9 +5,10 @@
#include "ash/keyboard/keyboard_ui.h"
#include "ash/common/accessibility_delegate.h"
+#include "ash/common/system/accessibility_observer.h"
+#include "ash/common/system/tray/wm_system_tray_notifier.h"
+#include "ash/common/wm_shell.h"
#include "ash/keyboard/keyboard_ui_observer.h"
-#include "ash/shell.h"
-#include "ash/system/tray/system_tray_notifier.h"
#include "ash/system/tray_accessibility.h"
#include "base/memory/ptr_util.h"
#include "ui/keyboard/keyboard_controller.h"
@@ -17,12 +18,13 @@ namespace ash {
class KeyboardUIImpl : public KeyboardUI, public AccessibilityObserver {
public:
KeyboardUIImpl() {
- // The Shell may not exist in some unit tests.
- Shell::GetInstance()->system_tray_notifier()->AddAccessibilityObserver(
- this);
+ WmShell::Get()->system_tray_notifier()->AddAccessibilityObserver(this);
}
- ~KeyboardUIImpl() override {}
+ ~KeyboardUIImpl() override {
+ if (WmShell::HasInstance() && WmShell::Get()->system_tray_notifier())
+ WmShell::Get()->system_tray_notifier()->RemoveAccessibilityObserver(this);
+ }
// KeyboardUI:
void Show() override {
@@ -33,8 +35,8 @@ class KeyboardUIImpl : public KeyboardUI, public AccessibilityObserver {
// to the appropriate keyboard functions.
}
bool IsEnabled() override {
- return Shell::GetInstance()
- ->accessibility_delegate()
+ return WmShell::Get()
+ ->GetAccessibilityDelegate()
->IsVirtualKeyboardEnabled();
}
« no previous file with comments | « ash/common/system/tray/wm_system_tray_notifier.cc ('k') | ash/magnifier/magnification_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698