Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2074913002: Enable the translate bubble to be dismissed when user ignores it. (Closed)

Created:
4 years, 6 months ago by hcarmona
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Enable the translate bubble to be dismissed when user ignores it. Refactored the dismiss mechanism from passwords to the location bar bubble delegate, which is a common location. Not all bubbles will need this because it's only necessary on bubbles that do not start focused. Like the passwords and translate bubbles. BUG=619192 Review-Url: https://codereview.chromium.org/2061523002 Cr-Commit-Position: refs/heads/master@{#399543} (cherry picked from commit 153dc6af7e1ac70671eefd48faed85c85cb151f0) Committed: https://chromium.googlesource.com/chromium/src/+/121eb7c1d28d7cec596748fe86917abbf6e18d18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -56 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 4 chunks +1 line, -53 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hcarmona
4 years, 6 months ago (2016-06-16 20:52:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
121eb7c1d28d7cec596748fe86917abbf6e18d18.

Powered by Google App Engine
This is Rietveld 408576698