Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 2074913002: Enable the translate bubble to be dismissed when user ignores it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.h
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.h b/chrome/browser/ui/views/translate/translate_bubble_view.h
index 6aa224d00c6a7a417fa88b05789d91b507330f7c..1042629d52f2710498ae46a64fb870d59baa5455 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.h
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.h
@@ -94,7 +94,7 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView,
bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
gfx::Size GetPreferredSize() const override;
- // views::CombboxListener methods.
+ // views::ComboboxListener methods.
void OnPerformAction(views::Combobox* combobox) override;
// views::LinkListener method.
@@ -126,6 +126,10 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView,
// Returns the current view state.
TranslateBubbleModel::ViewState GetViewState() const;
+ protected:
+ // LocationBarBubbleDelegateView:
+ void CloseBubble() override;
+
private:
enum LinkID {
LINK_ID_ADVANCED,
@@ -248,6 +252,8 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView,
// Whether the window is an incognito window.
const bool is_in_incognito_window_;
+ std::unique_ptr<WebContentMouseHandler> mouse_handler_;
+
DISALLOW_COPY_AND_ASSIGN(TranslateBubbleView);
};

Powered by Google App Engine
This is Rietveld 408576698