Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2061523002: Enable the translate bubble to be dismissed when user ignores it. (Closed)

Created:
4 years, 6 months ago by hcarmona
Modified:
4 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the translate bubble to be dismissed when user ignores it. Refactored the dismiss mechanism from passwords to the location bar bubble delegate, which is a common location. Not all bubbles will need this because it's only necessary on bubbles that do not start focused. Like the passwords and translate bubbles. BUG=619192 Committed: https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0 Cr-Commit-Position: refs/heads/master@{#399543}

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -56 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 4 chunks +1 line, -53 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.h View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hcarmona
PTAL Thanks!
4 years, 6 months ago (2016-06-13 18:11:09 UTC) #3
Peter Kasting
LGTM https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc (right): https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc#newcode32 chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:32: content::RenderViewHost* rvh = web_contents_->GetRenderViewHost(); Nit: Can just inline ...
4 years, 6 months ago (2016-06-13 20:27:25 UTC) #4
hcarmona
https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc (right): https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc#newcode32 chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:32: content::RenderViewHost* rvh = web_contents_->GetRenderViewHost(); On 2016/06/13 20:27:24, Peter Kasting ...
4 years, 6 months ago (2016-06-13 20:49:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061523002/40001
4 years, 6 months ago (2016-06-13 20:51:41 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-13 21:22:22 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:24:03 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0
Cr-Commit-Position: refs/heads/master@{#399543}

Powered by Google App Engine
This is Rietveld 408576698