Enable the translate bubble to be dismissed when user ignores it.

Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG=619192
Committed: https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0
Cr-Commit-Position: refs/heads/master@{#399543}

[hcarmona, 2016-06-11 00:45:49]

Description was changed from

==========
Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to a common location.
Implemented fix in translate bubble.

BUG=619192
==========

to

==========
Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG=619192
==========

[hcarmona, 2016-06-13 18:11:09]

hcarmona@chromium.org changed reviewers:
+ pkasting@chromium.org

[hcarmona, 2016-06-13 18:11:09]

PTAL

Thanks!

[Peter Kasting, 2016-06-13 20:27:25]

LGTM

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
(right):

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:32:
content::RenderViewHost* rvh = web_contents_->GetRenderViewHost();
Nit: Can just inline into the line below

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/translate/translate_bubble_view.h (right):

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/translate/translate_bubble_view.h:86: void CloseBubble()
override;
This was protected in the base class.  Does it need to be public here?

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/translate/translate_bubble_view.h:100: //
views::CombboxListener methods.
Nit: While here: Combobox

[hcarmona, 2016-06-13 20:49:03]

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
(right):

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:32:
content::RenderViewHost* rvh = web_contents_->GetRenderViewHost();
On 2016/06/13 20:27:24, Peter Kasting wrote:
> Nit: Can just inline into the line below

Done.

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/translate/translate_bubble_view.h (right):

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/translate/translate_bubble_view.h:86: void CloseBubble()
override;
On 2016/06/13 20:27:24, Peter Kasting wrote:
> This was protected in the base class.  Does it need to be public here?

Done, it's now protected.

https://codereview.chromium.org/2061523002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/translate/translate_bubble_view.h:100: //
views::CombboxListener methods.
On 2016/06/13 20:27:24, Peter Kasting wrote:
> Nit: While here: Combobox

Done.

[hcarmona, 2016-06-13 20:49:13]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-06-13 20:49:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2061523002/#ps40001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-06-13 20:51:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061523002/40001

[commit-bot: I haz the power, 2016-06-13 21:22:21]

Description was changed from

==========
Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG=619192
==========

to

==========
Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG=619192
==========

[commit-bot: I haz the power, 2016-06-13 21:22:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-13 21:24:01]

Description was changed from

==========
Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG=619192
==========

to

==========
Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG=619192

Committed: https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0
Cr-Commit-Position: refs/heads/master@{#399543}
==========

[commit-bot: I haz the power, 2016-06-13 21:24:03]

Patchset 3 (id:??) landed as
https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0
Cr-Commit-Position: refs/heads/master@{#399543}