Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: src/compiler/graph-visualizer.cc

Issue 2074323002: [Turbofan] Merge SpillRanges by byte_width rather than kind. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/register-allocator.h » ('j') | src/compiler/register-allocator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph-visualizer.cc
diff --git a/src/compiler/graph-visualizer.cc b/src/compiler/graph-visualizer.cc
index f2368931fa21ec3283c84f9260673b8e8b64464c..a63e69404d6a40b9c5f43e3ba6016f985525a59a 100644
--- a/src/compiler/graph-visualizer.cc
+++ b/src/compiler/graph-visualizer.cc
@@ -558,9 +558,10 @@ void GraphC1Visualizer::PrintLiveRange(const LiveRange* range, const char* type,
<< "\"";
} else {
index = AllocatedOperand::cast(top->GetSpillOperand())->index();
- if (top->kind() == FP_REGISTERS) {
- os_ << " \"double_stack:" << index << "\"";
- } else if (top->kind() == GENERAL_REGISTERS) {
+ if (IsFloatingPoint(top->representation())) {
+ os_ << " \"fp_stack:" << index << "\"";
+ } else {
+ DCHECK(!IsFloatingPoint(top->representation()));
Mircea Trofin 2016/06/18 23:27:56 When would this check fail?
bbudge 2016/06/18 23:33:22 Yes, that's kind of dumb. Removed.
os_ << " \"stack:" << index << "\"";
}
}
« no previous file with comments | « no previous file | src/compiler/register-allocator.h » ('j') | src/compiler/register-allocator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698