[Turbofan] Merge SpillRanges by byte_width rather than kind.

src/compiler/graph-visualizer.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/graph-visualizer.h"
 
 #include <sstream>
 #include <string>
 
 #include "src/code-stubs.h"
@@ skipping 540 matching lines @@
       const TopLevelLiveRange* top = range->TopLevel();
       int index = -1;
       if (top->HasSpillRange()) {
         index = kMaxInt;  // This hasn't been set yet.
       } else if (top->GetSpillOperand()->IsConstant()) {
         os_ << " \"const(nostack):"
             << ConstantOperand::cast(top->GetSpillOperand())->virtual_register()
             << "\"";
       } else {
         index = AllocatedOperand::cast(top->GetSpillOperand())->index();
-        if (top->kind() == FP_REGISTERS) {
-          os_ << " \"double_stack:" << index << "\"";
-        } else if (top->kind() == GENERAL_REGISTERS) {
+        if (IsFloatingPoint(top->representation())) {
+          os_ << " \"fp_stack:" << index << "\"";
+        } else {
+          DCHECK(!IsFloatingPoint(top->representation()));

[Mircea Trofin, 2016/06/18 23:27:56]

When would this check fail?

[bbudge, 2016/06/18 23:33:22]

Yes, that's kind of dumb. Removed.

           os_ << " \"stack:" << index << "\"";
         }
       }
     }
 
     os_ << " " << vreg;
     for (const UseInterval* interval = range->first_interval();
          interval != nullptr; interval = interval->next()) {
       os_ << " [" << interval->start().value() << ", "
           << interval->end().value() << "[";
@@ skipping 92 matching lines @@
         os << "]";
       }
       os << std::endl;
     }
   }
   return os;
 }
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8