Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: src/compiler/register-allocator.h

Issue 2074323002: [Turbofan] Merge SpillRanges by byte_width rather than kind. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/register-allocator.h
diff --git a/src/compiler/register-allocator.h b/src/compiler/register-allocator.h
index 933d1d2472974dc4804582618d050baab6805849..c92c3ef15a61b03c830ee327aba7923256bbff29 100644
--- a/src/compiler/register-allocator.h
+++ b/src/compiler/register-allocator.h
@@ -678,8 +678,6 @@ class SpillRange final : public ZoneObject {
SpillRange(TopLevelLiveRange* range, Zone* zone);
UseInterval* interval() const { return use_interval_; }
- // Currently, only 4 or 8 byte slots are supported.
- int ByteWidth() const;
bool IsEmpty() const { return live_ranges_.empty(); }
bool TryMerge(SpillRange* other);
bool HasSlot() const { return assigned_slot_ != kUnassignedSlot; }
@@ -696,8 +694,9 @@ class SpillRange final : public ZoneObject {
return live_ranges_;
}
ZoneVector<TopLevelLiveRange*>& live_ranges() { return live_ranges_; }
+ // Currently, only 4 or 8 byte slots are supported.
int byte_width() const { return byte_width_; }
- RegisterKind kind() const { return kind_; }
+ MachineRepresentation representation() const { return representation_; }
Mircea Trofin 2016/06/18 23:27:56 Check indentation here (may be just something weir
bbudge 2016/06/18 23:33:22 Seems OK.
void Print() const;
private:
@@ -710,8 +709,8 @@ class SpillRange final : public ZoneObject {
UseInterval* use_interval_;
LifetimePosition end_position_;
int assigned_slot_;
+ MachineRepresentation representation_;
int byte_width_;
- RegisterKind kind_;
DISALLOW_COPY_AND_ASSIGN(SpillRange);
};

Powered by Google App Engine
This is Rietveld 408576698