Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2074003002: Update GN build to use v8_target_cpu instead of v8_target_arch. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update GN build to use v8_target_cpu instead of v8_target_arch. R=jochen@chromium.org, machenbach@chromium.org, thakis@chromium.org BUG=chromium:619503 Committed: https://crrev.com/8756f6e90b48a38a32665f20f4093686ace5ccf3 Cr-Commit-Position: refs/heads/master@{#37048}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -57 lines) Patch
M BUILD.gn View 11 chunks +15 lines, -15 lines 0 comments Download
M build_overrides/v8.gni View 1 chunk +5 lines, -4 lines 1 comment Download
M gni/v8.gni View 2 chunks +1 line, -16 lines 0 comments Download
M test/cctest/BUILD.gn View 11 chunks +14 lines, -14 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-17 05:06:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074003002/1
4 years, 6 months ago (2016-06-17 05:06:20 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 05:30:37 UTC) #5
Michael Achenbach
Will land and clean up afterwards. lgtm https://codereview.chromium.org/2074003002/diff/1/build_overrides/v8.gni File build_overrides/v8.gni (right): https://codereview.chromium.org/2074003002/diff/1/build_overrides/v8.gni#newcode14 build_overrides/v8.gni:14: if (((v8_target_cpu ...
4 years, 6 months ago (2016-06-17 07:04:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074003002/1
4 years, 6 months ago (2016-06-17 07:04:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 07:06:32 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8756f6e90b48a38a32665f20f4093686ace5ccf3 Cr-Commit-Position: refs/heads/master@{#37048}
4 years, 6 months ago (2016-06-17 07:07:43 UTC) #11
Dirk Pranke
4 years, 6 months ago (2016-06-17 15:57:15 UTC) #12
Message was sent while issue was closed.
On 2016/06/17 07:04:15, Michael Achenbach wrote:
> Will land and clean up afterwards. lgtm
> 
> https://codereview.chromium.org/2074003002/diff/1/build_overrides/v8.gni
> File build_overrides/v8.gni (right):
> 
>
https://codereview.chromium.org/2074003002/diff/1/build_overrides/v8.gni#newc...
> build_overrides/v8.gni:14: if (((v8_target_cpu == "ia32" ||
> Yet another ia32 vs. x86 thing. Will clean up in a follow up.

Thanks. I checked for that but clearly missed it.

Powered by Google App Engine
This is Rietveld 408576698