build_overrides/v8.gni - Issue 2074003002: Update GN build to use v8_target_cpu instead of v8_target_arch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_overrides/v8.gni

Issue 2074003002: Update GN build to use v8_target_cpu instead of v8_target_arch. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_overrides/v8.gni

diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni

index 4e0bc803b5f7d1303dc2a84d5ac4370c66e9869a..ef3d8f469adac76c5b4f025e87afad6324ca9585 100644

--- a/build_overrides/v8.gni

+++ b/build_overrides/v8.gni

@@ -4,17 +4,18 @@

import("//build/config/features.gni")

import("//build/config/ui.gni")

+import("//build/config/v8_target_cpu.gni")

import("//gni/v8.gni")

if (is_android) {

import("//build/config/android/config.gni")

}

-if (((v8_target_arch == "ia32" ||

- v8_target_arch == "x64" ||

- v8_target_arch=="x87") &&

+if (((v8_target_cpu == "ia32" ||

Michael Achenbach 2016/06/17 07:04:15 Yet another ia32 vs. x86 thing. Will clean up in a

+ v8_target_cpu == "x64" ||

+ v8_target_cpu=="x87") &&

(is_linux || is_mac)) ||

- (v8_target_arch == "ppc64" && is_linux)) {

+ (v8_target_cpu == "ppc64" && is_linux)) {

v8_enable_gdbjit = true

}

« no previous file with comments | « BUILD.gn ('k') | gni/v8.gni » ('j') | no next file with comments »