Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: gni/v8.gni

Issue 2074003002: Update GN build to use v8_target_cpu instead of v8_target_arch. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index ec943a8fd435263281ce0772db9a63e80c10f82b..ae26521a6a98fadad77aadc422689fff9cd27141 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//build/config/sanitizers/sanitizers.gni")
+import("//build/config/v8_target_cpu.gni")
declare_args() {
# Turns on compiler optimizations in V8 in Debug build.
@@ -15,21 +15,6 @@ declare_args() {
# Use external files for startup data blobs:
# the JS builtins sources and the start snapshot.
v8_use_external_startup_data = !is_ios
-
- # V8 generates code for this architecture. If v8_target_arch differs from
- # target_cpu, a simulator will be run.
- v8_target_arch = ""
-}
-
-if (v8_target_arch == "") {
- if (is_msan) {
- # Running the V8-generated code on an ARM simulator is a powerful hack that
- # allows the tool to see the memory accesses from JITted code. Without this
- # flag, JS code causes false positive reports from MSan.
- v8_target_arch = "arm64"
- } else {
- v8_target_arch = target_cpu
- }
}
###############################################################################
« build_overrides/v8.gni ('K') | « build_overrides/v8.gni ('k') | test/cctest/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698