Removed all analyzer issues from tests

Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStore

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow

R=johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/c4cd62032d364f395e75692d78f7b33623104627

[cbernaschina, 2016-06-16 20:53:43]

Description was changed from

==========
Merge branch 'master' of https://github.com/dart-lang/sdk into hacking


Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStor

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

to

==========
Merge branch 'master' of https://github.com/dart-lang/sdk into hacking


Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStor

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

[cbernaschina, 2016-06-16 20:53:43]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[cbernaschina, 2016-06-16 20:54:10]

Description was changed from

==========
Merge branch 'master' of https://github.com/dart-lang/sdk into hacking


Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStor

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

to

==========
Merge branch 'master' of https://github.com/dart-lang/sdk into hacking


Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStore

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

[cbernaschina, 2016-06-16 21:03:40]

Description was changed from

==========
Merge branch 'master' of https://github.com/dart-lang/sdk into hacking


Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStore

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

to

==========
Removed all analyzer issues from tests


Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStore

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

[cbernaschina, 2016-06-16 21:03:49]

Description was changed from

==========
Removed all analyzer issues from tests


Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStore

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

to

==========
Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStore

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

[Cutch, 2016-06-16 21:38:23]

lots of little nits!

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
File
runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart
(right):

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart:26:
//suppress warning
We always start our comments with a space after the // and write full sentences
so:

// suppress unused variable warning.

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
File
runtime/observatory/tests/service/get_isolate_after_stack_overflow_error_test.dart
(right):

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/get_isolate_after_stack_overflow_error_test.dart:11:
//non tailable recursive function
here too

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/get_object_store_rpc_test.dart (right):

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:32: // Get
object_store
period at end of sentence

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:38: // Checking
Closures
period at end of sentence

[cbernaschina, 2016-06-16 21:50:21]

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
File
runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart
(right):

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart:26:
//suppress warning
On 2016/06/16 21:38:22, Cutch wrote:
> We always start our comments with a space after the // and write full
sentences
> so:
> 
> // suppress unused variable warning.

Done.

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
File
runtime/observatory/tests/service/get_isolate_after_stack_overflow_error_test.dart
(right):

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/get_isolate_after_stack_overflow_error_test.dart:11:
//non tailable recursive function
On 2016/06/16 21:38:22, Cutch wrote:
> here too

Done.

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/get_object_store_rpc_test.dart (right):

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:32: // Get
object_store
On 2016/06/16 21:38:22, Cutch wrote:
> period at end of sentence

Done.

https://codereview.chromium.org/2073893002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:38: // Checking
Closures
On 2016/06/16 21:38:22, Cutch wrote:
> period at end of sentence

Done.

[Cutch, 2016-06-16 21:56:41]

LGTM but let's wait for Todd and Ryan to weigh in too.

[turnidge, 2016-06-17 16:19:15]

lgtm with some small comments below.

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/get_object_store_rpc_test.dart (right):

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:1: // Copyright
(c) 2015, the Dart project authors.  Please see the AUTHORS file
2016

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:13:
developer.debugger(message: "fo", when: true);
Why "fo"?  Did you mean "foo"?

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:16: bool
isClosures(NamedField field) {
Change name from "isClosures" to "isClosure"

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:45: main(args)
=> runIsolateTestsSynchronous(args, tests, testeeConcurrent: doDebugger);
Maybe wrap this to 80-columns

[cbernaschina, 2016-06-17 18:06:28]

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/get_object_store_rpc_test.dart (right):

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:1: // Copyright
(c) 2015, the Dart project authors.  Please see the AUTHORS file
On 2016/06/17 16:19:15, turnidge wrote:
> 2016

Done.

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:13:
developer.debugger(message: "fo", when: true);
On 2016/06/17 16:19:15, turnidge wrote:
> Why "fo"?  Did you mean "foo"?

Done.

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:16: bool
isClosures(NamedField field) {
On 2016/06/17 16:19:15, turnidge wrote:
> Change name from "isClosures" to "isClosure"

It doesn't actually checks if it is a closure, it checks if it is the closures
list.

What about "isClosureFunctionsList"?

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:45: main(args)
=> runIsolateTestsSynchronous(args, tests, testeeConcurrent: doDebugger);
On 2016/06/17 16:19:15, turnidge wrote:
> Maybe wrap this to 80-columns

Done.

[rmacnak, 2016-06-20 23:11:40]

lgtm

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/get_object_store_rpc_test.dart (right):

https://codereview.chromium.org/2073893002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_object_store_rpc_test.dart:16: bool
isClosures(NamedField field) {
On 2016/06/17 18:06:27, cbernaschina wrote:
> On 2016/06/17 16:19:15, turnidge wrote:
> > Change name from "isClosures" to "isClosure"
> 
> It doesn't actually checks if it is a closure, it checks if it is the closures
> list.
> 
> What about "isClosureFunctionsList"?

Sounds good.

[cbernaschina, 2016-06-20 23:27:22]

Description was changed from

==========
Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStore

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow
==========

to

==========
Removed all analyzer issues from tests

Done by removing dead code, suppressing warning via getters, removed from
analysis files with intentional errors and warnings.

Added tests for rpc commands:
 - setName
 - _getObjectStore

Added tests for particular exceptions:
 - OutOfMemory
 - StackOverflow

R=johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c4cd62032d364f395e75692d78f7b33623104627
==========

[cbernaschina, 2016-06-20 23:27:24]

Committed patchset #4 (id:60001) manually as
c4cd62032d364f395e75692d78f7b33623104627 (presubmit successful).