Removed all analyzer issues from tests

runtime/observatory/tests/service/get_object_store_rpc_test.dart

+// Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file

[turnidge, 2016/06/17 16:19:15]

2016

[cbernaschina, 2016/06/17 18:06:28]

Done.

+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+// VMOptions=--error_on_bad_type --error_on_bad_override
+
+import 'package:observatory/service_io.dart';
+import 'package:unittest/unittest.dart';
+import 'service_test_common.dart';
+import 'test_helper.dart';
+import 'dart:developer' as developer;
+
+void doDebugger() {
+  developer.debugger(message: "fo", when: true);

[turnidge, 2016/06/17 16:19:15]

Why "fo"?  Did you mean "foo"?

[cbernaschina, 2016/06/17 18:06:27]

Done.

+}
+
+bool isClosures(NamedField field) {

[turnidge, 2016/06/17 16:19:15]

Change name from "isClosures" to "isClosure"

[cbernaschina, 2016/06/17 18:06:27]

It doesn't actually checks if it is a closure, it checks if it is the closures
list.

What about "isClosureFunctionsList"?

[rmacnak, 2016/06/20 23:11:39]

Sounds good.

+  return field.name == 'closure_functions_';
+}
+
+var tests = [
+
+// Initial data fetch and verify we've hit the breakpoint.
+(Isolate isolate) async {
+  await isolate.rootLibrary.load();
+  var script = isolate.rootLibrary.scripts[0];
+  await script.load();
+  await hasStoppedAtBreakpoint(isolate);
+  // Sanity check.
+  expect(isolate.pauseEvent.kind, equals(ServiceEvent.kPauseBreakpoint));
+},
+
+// Get object_store.
+(Isolate isolate) async {
+  var object_store = await isolate.getObjectStore();
+  expect(object_store.runtimeType, equals(ObjectStore));
+  // Sanity check.
+  expect(object_store.fields.length, greaterThanOrEqualTo(1));
+  // Checking Closures.
+  expect(object_store.fields.singleWhere(isClosures), isNotNull);
+  expect(object_store.fields.singleWhere(isClosures).value.isList, isTrue);
+}
+
+];
+
+main(args) => runIsolateTestsSynchronous(args, tests, testeeConcurrent: doDebugger);

[turnidge, 2016/06/17 16:19:15]

Maybe wrap this to 80-columns

[cbernaschina, 2016/06/17 18:06:28]

Done.