Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: runtime/observatory/tests/service/set_name_rpc_test.dart

Issue 2073893002: Removed all analyzer issues from tests (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Merge branch 'master' of https://github.com/dart-lang/sdk into tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/set_name_rpc_test.dart
diff --git a/runtime/observatory/tests/service/set_vm_name_rpc_test.dart b/runtime/observatory/tests/service/set_name_rpc_test.dart
similarity index 64%
copy from runtime/observatory/tests/service/set_vm_name_rpc_test.dart
copy to runtime/observatory/tests/service/set_name_rpc_test.dart
index 7e3a53a8e6f4166a8943ed89ae54c629dad5f427..bb3d8c8ab60511a50628f1c46ed002521f54a622 100644
--- a/runtime/observatory/tests/service/set_vm_name_rpc_test.dart
+++ b/runtime/observatory/tests/service/set_name_rpc_test.dart
@@ -3,33 +3,34 @@
// BSD-style license that can be found in the LICENSE file.
// VMOptions=--error_on_bad_type --error_on_bad_override --vm-name=Walter
-import 'dart:async';
import 'package:observatory/service_io.dart';
import 'package:unittest/unittest.dart';
import 'test_helper.dart';
+import 'dart:async';
var tests = [
- (VM vm) async {
- expect(vm.name, equals('Walter'));
+ (Isolate isolate) async {
+ expect(isolate.name, equals('set_name_rpc_test.dart\$main'));
Completer completer = new Completer();
- var stream = await vm.getEventStream(VM.kVMStream);
+ var stream = await isolate.vm.getEventStream(VM.kIsolateStream);
var subscription;
subscription = stream.listen((ServiceEvent event) {
- if (event.kind == ServiceEvent.kVMUpdate) {
- expect(event.owner.type, equals('VM'));
+ if (event.kind == ServiceEvent.kIsolateUpdate) {
+ expect(event.owner.type, equals('Isolate'));
expect(event.owner.name, equals('Barbara'));
subscription.cancel();
completer.complete();
}
});
-
- var result = await vm.setName('Barbara');
+
+ var result = await isolate.setName('Barbara');
expect(result.type, equals('Success'));
await completer.future;
- expect(vm.name, equals('Barbara'));
- },
+ expect(isolate.name, equals('Barbara'));
+
+ }
];
-main(args) async => runVMTests(args, tests, trace_service: true);
+main(args) async => runIsolateTests(args, tests);
« no previous file with comments | « runtime/observatory/tests/service/pause_on_exceptions_test.dart ('k') | runtime/observatory/tests/service/test_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698