Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2073643002: Use enum instead of "bool preserveSelection and bool preserveStyle" of moveParagraph() (Closed)

Created:
4 years, 6 months ago by joone
Modified:
4 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use enum instead of "bool preserveSelection and bool preserveStyle" of moveParagraph() This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types to CompositeEditCommand as follows: enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection }; enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle }; BUG=none Committed: https://crrev.com/1817607a8dc506b30d29e4adc3021237fa0054ec Cr-Commit-Position: refs/heads/master@{#400207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
joone
Hi Yosin, could you review this CL?
4 years, 6 months ago (2016-06-16 02:59:22 UTC) #4
yosin_UTC9
lgtm Great! This change makes improve readability well. Thanks so much! (^_^)b
4 years, 6 months ago (2016-06-16 05:44:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073643002/20001
4 years, 6 months ago (2016-06-16 06:16:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/240098)
4 years, 6 months ago (2016-06-16 10:07:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073643002/20001
4 years, 6 months ago (2016-06-16 16:44:03 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-16 18:13:28 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 18:13:40 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1817607a8dc506b30d29e4adc3021237fa0054ec Cr-Commit-Position: refs/heads/master@{#400207}
4 years, 6 months ago (2016-06-16 18:16:29 UTC) #17
joone
4 years, 6 months ago (2016-06-17 05:47:42 UTC) #18
Message was sent while issue was closed.
On 2016/06/16 05:44:07, Yosi_BlinkOn_UTC2 wrote:
> lgtm
> 
> Great! This change makes improve readability well.
> Thanks so much! (^_^)b

Thank you! :-)

Powered by Google App Engine
This is Rietveld 408576698