Use enum instead of "bool preserveSelection and bool preserveStyle" of moveParagraph()

Use enum instead of "bool preserveSelection and bool preserveStyle" of moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection };
enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle };

BUG=none

Committed: https://crrev.com/1817607a8dc506b30d29e4adc3021237fa0054ec
Cr-Commit-Position: refs/heads/master@{#400207}

[joone, 2016-06-16 00:28:42]

Patchset #1 (id:1) has been deleted

[joone, 2016-06-16 00:30:15]

Description was changed from

==========
Use enum instead of "bool preserveSelection and bool preserveStyle" of
moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection = true, DoNotPreserveSelection
= false };
enum ShouldPreserveStyle { PreserveStyle = true, DoNotPreserveStyle = false };

BUG=none
==========

to

==========
Use enum instead of "bool preserveSelection and bool preserveStyle" of
moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection};
enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle};

BUG=none
==========

[joone, 2016-06-16 02:59:22]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[joone, 2016-06-16 02:59:22]

Hi Yosin, could you review this CL?

[yosin_UTC9, 2016-06-16 05:44:07]

lgtm

Great! This change makes improve readability well.
Thanks so much! (^_^)b

[joone, 2016-06-16 06:15:47]

The CQ bit was checked by joone.hur@intel.com

[commit-bot: I haz the power, 2016-06-16 06:16:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073643002/20001

[joone, 2016-06-16 06:16:15]

Description was changed from

==========
Use enum instead of "bool preserveSelection and bool preserveStyle" of
moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection};
enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle};

BUG=none
==========

to

==========
Use enum instead of "bool preserveSelection and bool preserveStyle" of
moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection };
enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle };

BUG=none
==========

[commit-bot: I haz the power, 2016-06-16 10:07:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 10:07:47]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[joone, 2016-06-16 16:43:10]

The CQ bit was checked by joone.hur@intel.com

[commit-bot: I haz the power, 2016-06-16 16:44:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073643002/20001

[commit-bot: I haz the power, 2016-06-16 18:13:27]

Description was changed from

==========
Use enum instead of "bool preserveSelection and bool preserveStyle" of
moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection };
enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle };

BUG=none
==========

to

==========
Use enum instead of "bool preserveSelection and bool preserveStyle" of
moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection };
enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle };

BUG=none
==========

[commit-bot: I haz the power, 2016-06-16 18:13:28]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-06-16 18:13:40]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 18:16:28]

Description was changed from

==========
Use enum instead of "bool preserveSelection and bool preserveStyle" of
moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection };
enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle };

BUG=none
==========

to

==========
Use enum instead of "bool preserveSelection and bool preserveStyle" of
moveParagraph()

This CL adds ShouldPreserveSelection and ShouldPreserveStyle enum types
to CompositeEditCommand as follows:

enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection };
enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle };

BUG=none

Committed: https://crrev.com/1817607a8dc506b30d29e4adc3021237fa0054ec
Cr-Commit-Position: refs/heads/master@{#400207}
==========

[commit-bot: I haz the power, 2016-06-16 18:16:29]

Patchset 1 (id:??) landed as
https://crrev.com/1817607a8dc506b30d29e4adc3021237fa0054ec
Cr-Commit-Position: refs/heads/master@{#400207}

[joone, 2016-06-17 05:47:42]

On 2016/06/16 05:44:07, Yosi_BlinkOn_UTC2 wrote:
> lgtm
> 
> Great! This change makes improve readability well.
> Thanks so much! (^_^)b

Thank you! :-)