Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1786)

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2073643002: Use enum instead of "bool preserveSelection and bool preserveStyle" of moveParagraph() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
index cbb117aaf3b5a284bd36b70d044872a9f684b18b..9420106f2aff9e4246f9c15d9fc72a8cc2f87307 100644
--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
@@ -383,7 +383,7 @@ void InsertListCommand::unlistifyParagraph(const VisiblePosition& originalStart,
return;
VisiblePosition insertionPoint = createVisiblePosition(Position::beforeNode(placeholder));
- moveParagraphs(start, end, insertionPoint, editingState, /* preserveSelection */ true, /* preserveStyle */ true, listChildNode);
+ moveParagraphs(start, end, insertionPoint, editingState, PreserveSelection, PreserveStyle, listChildNode);
}
static HTMLElement* adjacentEnclosingList(const VisiblePosition& pos, const VisiblePosition& adjacentPos, const HTMLQualifiedName& listTag)
@@ -495,7 +495,7 @@ void InsertListCommand::moveParagraphOverPositionIntoEmptyListItem(const Visible
document().updateStyleAndLayoutIgnorePendingStylesheets();
const VisiblePosition& start = startOfParagraph(pos, CanSkipOverEditingBoundary);
const VisiblePosition& end = endOfParagraph(pos, CanSkipOverEditingBoundary);
- moveParagraph(start, end, createVisiblePosition(Position::beforeNode(placeholder)), editingState, true);
+ moveParagraph(start, end, createVisiblePosition(Position::beforeNode(placeholder)), editingState, PreserveSelection);
}
DEFINE_TRACE(InsertListCommand)
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698