Use enum instead of "bool preserveSelection and bool preserveStyle" of moveParagraph()

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

 /*
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 56 matching lines @@
     VisibleSelection m_startingSelection;
     VisibleSelection m_endingSelection;
     HeapVector<Member<SimpleEditCommand>> m_commands;
     Member<Element> m_startingRootEditableElement;
     Member<Element> m_endingRootEditableElement;
     EditAction m_editAction;
 };
 
 class CompositeEditCommand : public EditCommand {
 public:
+    enum ShouldPreserveSelection { PreserveSelection, DoNotPreserveSelection };
+    enum ShouldPreserveStyle { PreserveStyle, DoNotPreserveStyle };
+
     ~CompositeEditCommand() override;
 
     // Returns |false| if the command failed.  e.g. It's aborted.
     bool apply();
     bool isFirstCommand(EditCommand* command) { return !m_commands.isEmpty() && m_commands.first() == command; }
     EditCommandComposition* composition() { return m_composition.get(); }
     EditCommandComposition* ensureComposition();
 
     virtual bool isReplaceSelectionCommand() const;
     virtual bool isTypingCommand() const;
@@ skipping 62 matching lines @@
     HTMLBRElement* insertBlockPlaceholder(const Position&, EditingState*);
     HTMLBRElement* addBlockPlaceholderIfNeeded(Element*, EditingState*);
     void removePlaceholderAt(const Position&);
 
     HTMLElement* insertNewDefaultParagraphElementAt(const Position&, EditingState*);
 
     HTMLElement* moveParagraphContentsToNewBlockIfNecessary(const Position&, EditingState*);
 
     void pushAnchorElementDown(Element*, EditingState*);
 
-    // FIXME: preserveSelection and preserveStyle should be enums
-    void moveParagraph(const VisiblePosition&, const VisiblePosition&, const VisiblePosition&, EditingState*, bool preserveSelection = false, bool preserveStyle = true, Node* constrainingAncestor = nullptr);
-    void moveParagraphs(const VisiblePosition&, const VisiblePosition&, const VisiblePosition&, EditingState*, bool preserveSelection = false, bool preserveStyle = true, Node* constrainingAncestor = nullptr);
+    void moveParagraph(const VisiblePosition&, const VisiblePosition&, const VisiblePosition&, EditingState*, ShouldPreserveSelection = DoNotPreserveSelection, ShouldPreserveStyle = PreserveStyle, Node* constrainingAncestor = nullptr);
+    void moveParagraphs(const VisiblePosition&, const VisiblePosition&, const VisiblePosition&, EditingState*, ShouldPreserveSelection = DoNotPreserveSelection, ShouldPreserveStyle = PreserveStyle, Node* constrainingAncestor = nullptr);
     void moveParagraphWithClones(const VisiblePosition& startOfParagraphToMove, const VisiblePosition& endOfParagraphToMove, HTMLElement* blockElement, Node* outerNode, EditingState*);
     void cloneParagraphUnderNewElement(const Position& start, const Position& end, Node* outerNode, Element* blockElement, EditingState*);
     void cleanupAfterDeletion(EditingState*, VisiblePosition destination = VisiblePosition());
 
     bool breakOutOfEmptyListItem(EditingState*);
     bool breakOutOfEmptyMailBlockquotedParagraph(EditingState*);
 
     Position positionAvoidingSpecialElementBoundary(const Position&, EditingState*);
 
     Node* splitTreeToNode(Node*, Node*, bool splitAncestor = false);
 
     HeapVector<Member<EditCommand>> m_commands;
 
 private:
     bool isCompositeEditCommand() const final { return true; }
 
     Member<EditCommandComposition> m_composition;
 };
 
 DEFINE_TYPE_CASTS(CompositeEditCommand, EditCommand, command, command->isCompositeEditCommand(), command.isCompositeEditCommand());
 
 } // namespace blink
 
 #endif // CompositeEditCommand_h